Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 5 Sep 2025 21:23:30 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: jian he <jian.universality@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: NOT NULL NOT ENFORCED
Message-ID: <202509051923.n4xc5vthqyhu@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202509041200.iivbiv66fp62@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202509051923.n4xc5vthqyhu%40alvherre.pgsql>
Precedence: bulk

On 2025-Sep-04, Álvaro Herrera wrote:

> On 2025-Sep-04, jian he wrote:

> > +		else if (notenforced)
> > +		{
> > +			/*
> > +			 * We can't use ATExecSetNotNull here because it adds an enforced
> > +			 * not-null constraint, but here we only want a non-enforced one.
> > +			*/
> 
> Umm, wouldn't it make more sense to modify ATExecSetNotNull() so that it
> does what we want?  This seems hackish.

BTW while you're at that, it might make sense to allow commands like
  ALTER TABLE foo ALTER col1 SET NOT NULL NOT VALID
  ALTER TABLE foo ALTER col1 SET NOT NULL NOT ENFORCED

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"La verdad no siempre es bonita, pero el hambre de ella sí"