Feedback-ID: ie3de48e3:Fastmail
Date: Thu, 25 Sep 2025 20:12:41 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Antonin Houska <ah@cybertec.at>
Cc: Robert Treat <rob@xzilla.net>, Fujii Masao <masao.fujii@gmail.com>,
	Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <202509251758.t77p7r2ocmej@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="52vaejy5wnlkvc5v"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202508301750.cbohxyy2pcce@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202509251758.t77p7r2ocmej%40alvherre.pgsql>
Precedence: bulk


--52vaejy5wnlkvc5v
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

After looking at this some more, I realized that 0001 had been written a
bit too hastily and that it could use with some more cleanup -- in
particular, we don't need to export most of the function prototypes
other than vacuuming_main() (and the trivial escape_quotes helper).  I
made the other functions static.  Also, prepare_vacuum_command() also
needs the encoding in order to do fmtIdEnc() on a given index name (for
`pg_repackdb -t table --index=foobar`), so I changed it to take the
PGconn instead of just the serverVersion.  I realized that it makes no
sense that objfilter is a global variable instead of living inside
`main` and be passed as argument where needed.  (Heck, maybe it should
be inside vacuumingOpts).  Lastly, it seemed weird coding that the
functions would sometimes exit(1) instead of returning a result code, so
I made them do that and have the callers react appropriately.  These are
all fairly straightforward changes.

So here's v22 with those and rebased to current sources.  Only the first
two patches this time, which are the ones I would be glad to receive
input on.

I also wonder if analyze_only and analyze_in_stages should be new values
in RunMode rather than separate booleans ... I think that might make the
code simpler.  I didn't try though.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Los dioses no protegen a los insensatos.  Éstos reciben protección de
otros insensatos mejor dotados" (Luis Wu, Mundo Anillo)

--52vaejy5wnlkvc5v
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v22-0001-Split-vacuumdb-to-create-vacuuming.c-h.patch"