Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v28uQ-000hqr-DC for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Sep 2025 13:54:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v28tQ-001k38-C8 for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Sep 2025 13:53:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v28tP-001k2y-TX for pgsql-hackers@lists.postgresql.org; Fri, 26 Sep 2025 13:53:48 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v28tO-000EJs-0Q for pgsql-hackers@lists.postgresql.org; Fri, 26 Sep 2025 13:53:48 +0000 Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfout.stl.internal (Postfix) with ESMTP id 7B1B61D0007E; Fri, 26 Sep 2025 09:53:44 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Fri, 26 Sep 2025 09:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1758894824; x= 1758981224; bh=j/gnF417XUW9c/b5YoQEi4pktllzW3hHgr/+hnEuToI=; b=A XvZr7S6BfUVrg4x2d5uk9dEtgYXdRbo/LHdB/tjW9pMJGquTd4xq9QiS1TGCXXl8 ekodQZzO9NJoKxj9TF+j/FOP6jBURlv9ktlY7QCG0FRGIxyx5VotvxLFgYJ+fqw+ uw0Wehm2mHMq28wsOVY0WaxTw0AipT77X/PMHvUQESFhLooI4+yUx9cjbgFsh4ya m3xAxs0g8GKSXegG6JHn6eI9USpLf9RW7yYqmPtDZEbImWks6eBdnkdohfN6Dehz rUTiQ/vjJ/jUMvSE7LY7v3DobYVwytlhFONFGr0u+FCTU/TcJYrcdgJJaJjpMKeH bUh8+HTU+HZEpH5PTQWlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1758894824; x=1758981224; bh=j /gnF417XUW9c/b5YoQEi4pktllzW3hHgr/+hnEuToI=; b=qZojI4emeWy/Vl6L2 t1LNjpjra6C/uc9f+R+iK0XrouOgPQ86HwZeQ0jiCYm6ezvJ3kSkC3h2BY+S3E0E BgDoXcsZaH7uwqNHrrF0h1W1wxp3B2jXZRVSegjag02oDz/kfo5ZnsYyHJ5mM7LE SIuRI8epIC6XA0rB2jsyn8mrjVObcSNUVaXwbhdIicI8pJWkW1sFno4KBlGfJTYz mCkxVrBZL7P+/y7fhLe67/mygZaDVcX5D4N4yth1pZUEdELf4WiOJdPHU9hNlaKr P7s+EizlnFt13GtGSrJIP8Ps8WHywIo3/zMFUEf+QuL3mgMg32Ms4YZzgHRMeFb/ Joaow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdeileehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpemllhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepteeuvdehffekvefgueehveetveekgfegtddtueefueehuddutdfhfeff hfejfeffnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprghhsegthigsvghrthgvtgdrrghtpdhrtghpthhtohepphhgshhq lhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Sep 2025 09:53:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1758894819; bh=l1R1Bnvjw0ytC69MfECktTLDkIx9PWvPKOd7gyMZBj0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=g5SDSY8DyUlTuf0hD/uUBSw4424xLNYr4GFp3yx+rV9cXYeL+0COsHK+DlMuj4t1s 9BgEY0SGmUMsLP93PjYBhLojqtORBW1PMwk3Yeoa8CqwKs7gliAO5GHQh9QvdDcYRN L6MTuNgKD9eL8eg/RZDooGgUCdWHYRfZrdi2l6SwhONPEXwNK7OADyatNQdWFutrlX KciE4m+KKi13X61MJlT9suJtWFr6s6L5ZRxXiAW+3rXUwx5bAaPC02eaWnm3F1xO2I igSe7ntNMiM0bU4xCAgeJgSJskcaBLHMgHmU/MUYUhUZ8fqu8HxZIMVQ+xEl9dLusc NJ4s4r2XjssZA== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id F23DE78; Fri, 26 Sep 2025 15:53:39 +0200 (CEST) Date: Fri, 26 Sep 2025 15:53:39 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Antonin Houska Cc: Pg Hackers Subject: Re: splitting src/bin/scripts/vacuumdb.c Message-ID: <202509261350.nnoidrv2ryaf@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48811.1758894395@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Sep-26, Antonin Houska wrote: > I agree that redundant information makes things more difficult to > think about. I just wonder if > > vacopts->mode != MODE_VACUUM > > should be used instead of > > (vacopts->mode == MODE_ANALYZE || > vacopts->mode == MODE_ANALYZE_IN_STAGES) I don't think so, because it'd become (vacopts->mode != MODE_VACUUM && vacopts->mode != MODE_REPACK) after we introduce repack, which looks worse. I considered introducing a simple macro for this usage, something like #define ModeIsAnalyze(mode) (mode == MODE_ANALYZE || mode == MODE_ANALYZE_IN_STAGES) but thought it'd be overkill. > Other than that, I checked differences between v21, v22 and v23. I've got no > other comments worth posting. Thanks for looking! -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Pido que me den el Nobel por razones humanitarias" (Nicanor Parra)