Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3YmA-000TnQ-Fz for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Sep 2025 11:44:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v3Ym7-0098PP-P3 for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Sep 2025 11:44:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v3Ym7-0098OK-DV for pgsql-hackers@lists.postgresql.org; Tue, 30 Sep 2025 11:44:08 +0000 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v3Ym5-000tKH-1s for pgsql-hackers@postgresql.org; Tue, 30 Sep 2025 11:44:07 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8220414000FC; Tue, 30 Sep 2025 07:44:03 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Tue, 30 Sep 2025 07:44:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1759232643; x= 1759319043; bh=/cI2MRDktFfkVLDUp9EnZH2SxgpkgVLT81kShpPwIgg=; b=R FBQzJ7ZdnKwD4GxX6beOoGizPM58m4SBIHxawHSfd7DqfDIECJCACJRB1NzKysTN +OGAUy9nW0vHUpvQFcKugD5yqoLJRKjPNMr5jmXibzeqtSyDw+05E4LM1ZvbpwMI nSw1BUDRom/NBQ5xhB8GkWBREJy9WzAhf9wxgSjeBQgxrY/GdATOGlenTwp7H7SH stzdRCaGba4zHNJ3HIoTEN1+iQJiT3MyVqGYQybPfj3JRZJnR5dgf57eZB/474ef d6wUFd79n5Ur2m9ph6Pw3Xe7ksfQInQiOem96w6AsNGOqOT5EjYP6ewRXqmttmSX 5K/2hL5JnN/cGlXaoKr8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1759232643; x=1759319043; bh=/ cI2MRDktFfkVLDUp9EnZH2SxgpkgVLT81kShpPwIgg=; b=rDLw9IQGYJEbjne/d rJOT2fSOBWKc+qzGQBUUAuWpgCqtrC1lCEtMFsI5JAblQDBqQkF0pi9+0KQExkZb LylEGUX1vTUdZDx/EXBltuuI/BQOEF0KsSc16vOEAW2aEF+c/8EwAr1gBIoBm4iH eYh25LFqr19MjWF4F3qzbOgfxpIWLpZ3MZNgGUc4DAi8mnQOz8lLvxxPVnR8l9dn 25OxsD+G6k0VI2aUd/eDhFJ4rpbF3G4RsI1h5QwX5bwT+02nb2ctzV9LUC4xaC6z gzQOGIckO0+btNkVAOONQKzpFdW6LH5TiOnm9p+7f4fJdPDEiOz08W6IQRxk9Fsf aHhsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdektdejkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpemllhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepteeuvdehffekvefgueehveetveekgfegtddtueefueehuddutdfhfeff hfejfeffnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepgedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhgpdhrtghpthht oheprghshhhuthhoshhhrdgsrghprghtrdhoshhssehgmhgrihhlrdgtohhmpdhrtghpth htoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpdhrtghpthhtohepphhg shhqlhdqhhgrtghkvghrshesphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 30 Sep 2025 07:44:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1759232641; bh=VAAj+sOfVonW4wEjYQCwYmd0eUcPK0Nr76q4yMnuxxU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=01Wlrl0p9utO2fjWZIvtXIiJmiPHyHMxN59o56nhQS8gBFtRZy0+dm+b+2unEws6N nRajM3wtFSS/YygAPts6i1fWQUG+NQousCz1mud7RyYM0dHfY6KhladR5I4bts8TBD 16mI9vDb+5GAb1mV6QhVsfRqwhgQmWJu50t0PGJ6UIDUwha0L167pFM2IjkEE/7Rar bWbFgvyxGQqAKQj5XfPDRzS3w8xzy6Ye1rN2C96qtEqWakUKRzKiyyg+5vgolmhwjq YUVQK8rASnwR1hh04swYTIXQFzEqWX/x7kAzO58QbZQTTqAzaJ6gTIrSulu/9MESVD OqbCYdvhMSpYA== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 0711276; Tue, 30 Sep 2025 13:44:01 +0200 (CEST) Date: Tue, 30 Sep 2025 13:44:00 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Ashutosh Bapat Cc: Chao Li , Peter Eisentraut , pgsql-hackers Subject: Re: anonymous unions (C11) Message-ID: <202509301141.4wu7rvxai54d@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Sep-30, Ashutosh Bapat wrote: > Attached patch fixes those errors for me. > diff --git a/src/common/cryptohash.c b/src/common/cryptohash.c > index fc0555d2f99..e8a35c2ec35 100644 > --- a/src/common/cryptohash.c > +++ b/src/common/cryptohash.c > @@ -61,7 +61,7 @@ struct pg_cryptohash_ctx > pg_sha256_ctx sha256; > pg_sha384_ctx sha384; > pg_sha512_ctx sha512; > - } data; > + }; > }; Isn't this patch 0015 in Peter's series? -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ "Saca el libro que tu religión considere como el indicado para encontrar la oración que traiga paz a tu alma. Luego rebootea el computador y ve si funciona" (Carlos Duclós)