Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v50uc-0001w0-Mx for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Oct 2025 11:58:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v50ta-0000Iv-U6 for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Oct 2025 11:57:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v50ta-0000Im-2P for pgsql-hackers@lists.postgresql.org; Sat, 04 Oct 2025 11:57:51 +0000 Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1v50tY-001ME6-15 for pgsql-hackers@lists.postgresql.org; Sat, 04 Oct 2025 11:57:50 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 780A2140010F; Sat, 4 Oct 2025 07:57:47 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Sat, 04 Oct 2025 07:57:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1759579067; x= 1759665467; bh=3yuTPzRI5OI++yHJ8x5yoRTnhPFOxCCyJYyblt8U41o=; b=Z 6fvZrVkTJoTvqA3UdtWF4h2+l5kW2Ws4Wvns6RxEYkRc6ZTofPyi9z8XCqhRQKoA C8ZlBuKVFxFDHRuLKtSvW8D4uIkVn7g7MsHLz+3fQImhxwyU4KyZgM5XmmpykVso aRcwmwXReBwH9HTJMjkU+2SIuk4dOXFWDdllB3j3bUZAX8OzKfhO3omiFtRg5BIT pSkHTn+7AWHnnA0oMBFWX0jllrnXV/4lzhFxtoWjg8MTUJiOXLKqugzdCINkYHqz BFYrKcTRBYbN2tWgUPaMOOwLmayZ/ifoooNScCZZpoGuKe/LFjl2D+f834xzHvI2 Z2/EVOEliisS6tY3ySqqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1759579067; x=1759665467; bh=3 yuTPzRI5OI++yHJ8x5yoRTnhPFOxCCyJYyblt8U41o=; b=dTFsYzo5ouLnQHOS4 0/ViX5YYFGxkXdPyxLVrEvCBVzUN5RHL03dAiDMJgGp3nTMn/xSnSwmUbe86A6Wm 0DOBpEkiV8NL6aFk9hrp5USOwk5DmUAXmhgxqYNUaRCbZoIkc1R+EP2Ed1wFYE5L mNeDR6Vl+fKPjaW6qhXSJ7lqIyDn+ui5hK7E1/WOg3mfwKlIIGCxTc7AJq9ZfmZv mLe4J0iW7OXwgFl1y5QBt0qj6eoJcTEQ8lNB6D3UsjuWZzrttoQLGjfu6ntpaMsm 4VJIVxXl0G8BATuO8bpluuVJdqedWa5gkRX0WDGbM51kNvRqjLq+/YKIm0fgt7Nk VR7WQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdeludejvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpemllhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepteeuvdehffekvefgueehveetveekgfegtddtueefueehuddutdfhfeff hfejfeffnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtohepkhhurhhouggrrdhhrgihrghtohesfhhujhhithhsuhdrtghomhdp rhgtphhtthhopehsmhhithhhphgsvddvhedtsehgmhgrihhlrdgtohhmpdhrtghpthhtoh epphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 4 Oct 2025 07:57:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1759579064; bh=3nHlbwD7YbFiSqJD42jn1wxEJveSH4jaHBXsGb+1778=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Jz6UIangjIHSpW8/Yry3FH1i5GTdwCUe/JYIWBvbrHPSDvpHWE47+gGPGIrz2KD/c thMS72MG7zTahtsQm8GEZhqfUqQcOaJ+UQlfj9rvq7D0OAsmD2znMsA+AuvRoxNbxV ow5tk0nq7wmdLyG0dSDIWLUFpPQLrDRCHcutNi6oRjgphvvyTl8laA8xKavGmwOCUX uzL+7HHScp8v73GXBSUk2fcgNQ2t62CiuaBwzu4+Gqjj5TznettMnIjdxLUmmMKuic s0w+fY1z8os8B8E3StTHc4HQEkhCMXEkdegMsOTjakulaMC33/aYpXWjUJ66P4p5WK +iYbeB4gQ9tug== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 2A8AC7A; Sat, 04 Oct 2025 13:57:44 +0200 (CEST) Date: Sat, 4 Oct 2025 13:57:44 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Peter Smith Cc: "Hayato Kuroda (Fujitsu)" , PostgreSQL Hackers Subject: Re: pg_createsubscriber --dry-run logging concerns Message-ID: <202510041156.qwirsemadsvd@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Oct-03, Peter Smith wrote: > Summary > > The idea to change the pg_log_info macro globally seems risky. There > are 400+ usages of this in the PG code, way beyond the scope of these > few tools that have a dry-run. Ok. > So, that makes pg_createsubscriber the odd man out. Instead of > introducing a new logging macro, perhaps it's better (for code > consistency) just to change pg_createsubscriber to use that same > logging pattern. Sure, let's go that way. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/