Date: Mon, 06 Oct 2025 09:28:13 +0900 (JST)
Message-Id: <20251006.092813.1105116428701000307.ishii@postgresql.org>
To: tgl@sss.pgh.pa.us
Cc: ojford@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com,
 krasiyan@gmail.com, vik@postgresfriends.org, andrew@tao11.riddles.org.uk,
 david@fetter.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <1690746.1759682146@sss.pgh.pa.us>
References: <20251003.100606.2086363717963832725.ishii@postgresql.org>
	<1686755.1759679957@sss.pgh.pa.us>
	<1690746.1759682146@sss.pgh.pa.us>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20251006.092813.1105116428701000307.ishii%40postgresql.org>
Precedence: bulk

> Looking around, there is only one in-core caller of
> WinGetFuncArgInPartition, and it does pass a valid "isout" pointer,
> explaining why this inconsistency wasn't obvious in testing.
> There are outside callers though according to Debian Code Search,
> and at least PostGIS is one that passes a null pointer.
> 
> As Alvaro notes nearby, this function is ridiculously complicated
> already.  I'm tempted to remove the API allowance for isout == NULL,
> and thereby simplify the code slightly, rather than complicate it more
> by continuing to allow that.  We'd have to warn the PostGIS people
> about the API change though.

It think it's a good idea.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp