Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 8 Oct 2025 18:13:54 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jelte Fennema-Nio <me@jeltef.nl>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Mario =?utf-8?B?R29uesOhbGV6?= Troncoso <gonzalemario@gmail.com>,
 "David G. Johnston" <david.g.johnston@gmail.com>
Subject: Re: New commitfest app release on August 19th
Message-ID: <202510081607.x7ftlr6fb6lt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAGECzQTG4vSr_1goeWVrw2EGsjfGD-DCDqvCMqZSr2JtKoRqRA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202510081607.x7ftlr6fb6lt%40alvherre.pgsql>
Precedence: bulk

We just witnessed something weird with a patch that's perhaps a bug in
the workflow for detecting attachments.  Patch in question was
https://commitfest.postgresql.org/patch/5972/

1. patch was in CF19-2
2. patch needed rebase.
3. Mario sent a new mail with rebased git-format-patch to the thread
4. patch continued to need rebase. In fact, it appeared as if the thread
   info was not updated at all.
5. Mario moved the CF item to CF19-3
6. Nothing appeared to change, i.e. the thread display said that the
   last email was from Peter, ignoring the new email.
7. I detached the thread from the CF item, then attached the thread
   again.  This time it showed both messages, but the attachment list
   continued to show only the old one, ignoring the new patch.

Any thoughts?  One idea is to delete the CF item and create it afresh :-)


I *suspect* that the thread-processor ignored the attachment because of
CF19-2 being dead, but had already imported the email message; and then
when the patch was moved to CF19-3, the new email was not processed
again so the attachment was again not seen.  Does that make sense?

Thanks!

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Postgres is bloatware by design: it was built to house
 PhD theses." (Joey Hellerstein, SIGMOD annual conference 2002)