Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v7SNV-002zia-7Q for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Oct 2025 05:42:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v7SNR-00FMCY-GE for pgsql-hackers@arkaria.postgresql.org; Sat, 11 Oct 2025 05:42:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v7SNR-00FMCP-6V for pgsql-hackers@lists.postgresql.org; Sat, 11 Oct 2025 05:42:46 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v7SNP-001XMS-0k for pgsql-hackers@lists.postgresql.org; Sat, 11 Oct 2025 05:42:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender :Reply-To:Content-ID:Content-Description; bh=jhHEy0vLVI5ZHDpb8R5VhCMcb77zhburlU69ngjfo9c=; b=AKXN+dGHpYyD4Tw4XOazyRL3/G WKedfB1sv3LSQ3hIipWFIyRxSeM03te8vDmiF7BThgy/1a25aKU6p201j/ciCwtF0n7Z7Q7yNwrmw AqCd/nT6E35So8zNcNXJuAnfwE66h6R632KqKKUEwVNTSYUVPTmjKv4y4GSr9pzWd8K1xsBnSRAMI xbamz/JeIm1vmIA0wvpYnOMxe9bMyFy/4YaFa2ynMweOINlmlLHGIKelTt0IRrehhfZ57lwJzONQo aG9YTc3CNR8phGidN1zivLVhVmfmE4eDz8xWY5VtIYdSjTiGcNxo4woX84RZkMefrZ06tswMjEm9F rEudz3SQ==; Received: from [2409:11:4120:300:b8b1:8745:da7d:a6d8] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v7SNF-0049No-2r; Sat, 11 Oct 2025 05:42:36 +0000 Date: Sat, 11 Oct 2025 14:42:18 +0900 (JST) Message-Id: <20251011.144218.1729318385118014326.ishii@postgresql.org> To: tgl@sss.pgh.pa.us Cc: pramsey@cleverelephant.ca, ojford@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com, krasiyan@gmail.com, vik@postgresfriends.org, andrew@tao11.riddles.org.uk, david@fetter.org, pgsql-hackers@lists.postgresql.org Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options From: Tatsuo Ishii In-Reply-To: <20251011.090731.1451293026979559494.ishii@postgresql.org> References: <20251008.093117.1326499841464447981.ishii@postgresql.org> <2952409.1760023154@sss.pgh.pa.us> <20251011.090731.1451293026979559494.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Sat_Oct_11_14_42_18_2025_052)--" Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:b8b1:8745:da7d:a6d8 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ----Next_Part(Sat_Oct_11_14_42_18_2025_052)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit >> Also the error is certainly user-facing, >> so using elog() was quite inappropriate. It should be ereport with an >> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED. Rolling your >> own implementation of get_func_name() wasn't great either. > > I overlooked the elog() call and "own implementation of > get_func_name()". Will fix. Attached is a trivial patch to fix that. I am going to push it if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp ----Next_Part(Sat_Oct_11_14_42_18_2025_052)-- Content-Type: Application/Octet-Stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch" RnJvbSA2MWI0MzkzYmQxMmFkMjg2ZTczNWEzYmRmNzkzNDQzZWNiZjNiMWFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUYXRzdW8gSXNoaWkgPGlzaGlpQHBvc3RncmVzcWwub3JnPgpE YXRlOiBTYXQsIDExIE9jdCAyMDI1IDE0OjMxOjEyICswOTAwClN1YmplY3Q6IFtQQVRDSCB2MV0g VXNlIGVyZXBvcnQgcmF0aGVyIHRoYW4gZWxvZyBpbgogV2luQ2hlY2tBbmRJbml0aWFsaXplTnVs bFRyZWF0bWVudC4KClByZXZpb3VzbHkgV2luQ2hlY2tBbmRJbml0aWFsaXplTnVsbFRyZWF0bWVu dCgpIHVzZWQgZWxvZygpIHRvIGVtaXQgYW4KZXJyb3IgbWVzc2FnZS4gZXJlcG9ydCgpIHNob3Vs ZCBiZSB1c2VkIGluc3RlYWQgYmVjYXVzZSBpdCdzIGEKdXNlci1mYWNpbmcgZXJyb3IuCgpBbHNv IGZpeCBXaW5DaGVja0FuZEluaXRpYWxpemVOdWxsVHJlYXRtZW50KCkgdG8gdXNlIGV4aXN0aW5n CmdldF9mdW5jX25hbWUoKSB0byBnZXQgYSBmdW5jdGlvbidzIG5hbWUsIHJhdGhlciB0aGFuIG93 bgppbXBsZW1lbnRhdGlvbi4KClJlcG9ydGVkLWJ5OiBUb20gTGFuZSA8dGdsQHNzcy5wZ2gucGEu dXM+CkF1dGhvcjogVGF0c3VvIElzaGlpIDxpc2hpaUBwb3N0Z3Jlc3FsLm9yZz4KRGlzY3Vzc2lv bjogaHR0cHM6Ly9wb3N0Z3IuZXMvbS8yOTUyNDA5LjE3NjAwMjMxNTQlNDBzc3MucGdoLnBhLnVz Ci0tLQogc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZVdpbmRvd0FnZy5jIHwgMTkgKysrKysrLS0t LS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZVdpbmRvd0FnZy5jIGIv c3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZVdpbmRvd0FnZy5jCmluZGV4IGU2YTUzZjk1MzkxLi44 OTJiZGJkNWVmNSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvZXhlY3V0b3Ivbm9kZVdpbmRvd0Fn Zy5jCisrKyBiL3NyYy9iYWNrZW5kL2V4ZWN1dG9yL25vZGVXaW5kb3dBZ2cuYwpAQCAtMzU0MCwy MiArMzU0MCwxNSBAQCBXaW5DaGVja0FuZEluaXRpYWxpemVOdWxsVHJlYXRtZW50KFdpbmRvd09i amVjdCB3aW5vYmosCiB7CiAJaWYgKHdpbm9iai0+aWdub3JlX251bGxzICE9IE5PX05VTExUUkVB VE1FTlQgJiYgIWFsbG93TnVsbFRyZWF0bWVudCkKIAl7Ci0JCUhlYXBUdXBsZQlwcm9jdHVwOwot CQlGb3JtX3BnX3Byb2MgcHJvY2Zvcm07Ci0JCU9pZAkJCWZ1bmNpZDsKLQotCQlmdW5jaWQgPSBm Y2luZm8tPmZsaW5mby0+Zm5fb2lkOwotCQlwcm9jdHVwID0gU2VhcmNoU3lzQ2FjaGUxKFBST0NP SUQsCi0JCQkJCQkJCSAgT2JqZWN0SWRHZXREYXR1bShmdW5jaWQpKTsKLQkJaWYgKCFIZWFwVHVw bGVJc1ZhbGlkKHByb2N0dXApKQotCQkJZWxvZyhFUlJPUiwgImNhY2hlIGxvb2t1cCBmYWlsZWQg Zm9yIGZ1bmN0aW9uICV1IiwgZnVuY2lkKTsKLQkJcHJvY2Zvcm0gPSAoRm9ybV9wZ19wcm9jKSBH RVRTVFJVQ1QocHJvY3R1cCk7Ci0JCWVsb2coRVJST1IsICJmdW5jdGlvbiAlcyBkb2VzIG5vdCBh bGxvdyBSRVNQRUNUL0lHTk9SRSBOVUxMUyIsCi0JCQkgTmFtZVN0cihwcm9jZm9ybS0+cHJvbmFt ZSkpOworCQljaGFyCSAgICpmdW5jbmFtZSA9IGdldF9mdW5jX25hbWUoZmNpbmZvLT5mbGluZm8t PmZuX29pZCk7CisKKwkJZXJlcG9ydChFUlJPUiwKKwkJCQkoZXJyY29kZShFUlJDT0RFX0ZFQVRV UkVfTk9UX1NVUFBPUlRFRCksCisJCQkJIGVycm1zZygiZnVuY3Rpb24gJXMgZG9lcyBub3QgYWxs b3cgUkVTUEVDVC9JR05PUkUgTlVMTFMiLAorCQkJCQkJZnVuY25hbWUpKSk7CiAJfQogCWVsc2Ug aWYgKHdpbm9iai0+aWdub3JlX251bGxzID09IFBBUlNFUl9JR05PUkVfTlVMTFMpCiAJCXdpbm9i ai0+aWdub3JlX251bGxzID0gSUdOT1JFX05VTExTOwotCiB9CiAKIC8qCi0tIAoyLjQzLjAKCg== ----Next_Part(Sat_Oct_11_14_42_18_2025_052)----