Date: Sat, 11 Oct 2025 18:11:03 +0900 (JST)
Message-Id: <20251011.181103.1209570651155443747.ishii@postgresql.org>
To: tgl@sss.pgh.pa.us
Cc: pramsey@cleverelephant.ca, ojford@gmail.com, peter@eisentraut.org,
 li.evan.chao@gmail.com, krasiyan@gmail.com, vik@postgresfriends.org,
 andrew@tao11.riddles.org.uk, david@fetter.org,
 pgsql-hackers@lists.postgresql.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20251011.090731.1451293026979559494.ishii@postgresql.org>
References: <20251008.093117.1326499841464447981.ishii@postgresql.org>
	<2952409.1760023154@sss.pgh.pa.us>
	<20251011.090731.1451293026979559494.ishii@postgresql.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20251011.181103.1209570651155443747.ishii%40postgresql.org>
Precedence: bulk

>> I think it should be set up
>> so that if the window function fails to call that, then something in
>> mainline execution of nodeWindowAgg.c throws an error when there had
>> been a RESPECT/IGNORE NULLS option.  With that idea, you could drop
>> the allowNullTreatment argument and just have the window functions
>> that support this syntax call something named along the lines of
>> WinAllowNullTreatmentOption.
> 
> Does that mean all user defined window functions start to fail after
> upgrading to PostgreSQL 19?  I am not sure if it's acceptable for
> extension developers and their users.

Probably I misunderstood what you said. Now I realize what you are
suggesting was, throwing an error *only* when a RESPECT/IGNORE NULLS
option is given and the function did not call
WinAllowNullTreatmentOption. If the option is not given, no error is
thrown even if WinAllowNullTreatmentOption is not called. I am okay
with this direction. I will post a patch for this.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp