Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v8UZg-001YNi-MY for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Oct 2025 02:15:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1v8UZd-009hJl-Fq for pgsql-hackers@arkaria.postgresql.org; Tue, 14 Oct 2025 02:15:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1v8UZc-009hJd-3x for pgsql-hackers@lists.postgresql.org; Tue, 14 Oct 2025 02:15:38 +0000 Received: from mail.clear-code.com ([153.126.203.179]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1v8UZZ-001dCZ-1l for pgsql-hackers@postgresql.org; Tue, 14 Oct 2025 02:15:36 +0000 Received: from localhost (unknown [IPv6:2404:7a80:9f01:f500:5950:362a:f311:d0d2]) by mail.clear-code.com (Postfix) with ESMTPSA id D50D86EB5D5; Tue, 14 Oct 2025 11:15:26 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.clear-code.com D50D86EB5D5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clear-code.com; s=default; t=1760408127; bh=Ryglo5jLCiOIHh7AYih4GoLzhf3/T0nTw1RXKmTqPuY=; h=Date:To:Cc:Subject:From:In-Reply-To:References:From; b=hSmqks56i2gJ7WWAlpIFpjVGhVMtxC6NAvEiWAvkT0GKxaMpY1yt597b1imc+ewGz domUQyONz2pVE48RN7o0NeDvfXL5ehv5A87g1TS9seoSlydiTyZXDMbky2lGkfvKpo nbk7bnMRrapo7f9cp2SkggO7Yrf1uguiS/BKEsu8= Date: Tue, 14 Oct 2025 11:15:24 +0900 (JST) Message-Id: <20251014.111524.966856440891708928.kou@clear-code.com> To: sawada.mshk@gmail.com Cc: andres@anarazel.de, michael@paquier.xyz, david.g.johnston@gmail.com, tgl@sss.pgh.pa.us, zhjwpku@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Make COPY format extendable: Extract COPY TO format implementations From: Sutou Kouhei In-Reply-To: References: <20251003.160650.355943655010493993.kou@clear-code.com> X-Mailer: Mew version 6.8 on Emacs 30.1 Mime-Version: 1.0 Content-Type: Multipart/Mixed; boundary="--Next_Part(Tue_Oct_14_11_15_24_2025_315)--" Content-Transfer-Encoding: 7bit X-Rspamd-Server: mail.clear-code.com X-Spamd-Result: default: False [2.90 / 999.00]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-patch]; TAGGED_RCPT(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; ASN(0.00)[asn:2518, ipnet:2404:7a80::/29, country:JP]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; FREEMAIL_CC(0.00)[anarazel.de,paquier.xyz,gmail.com,sss.pgh.pa.us,postgresql.org] X-Rspamd-Queue-Id: D50D86EB5D5 X-Rspamd-Action: no action List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ----Next_Part(Tue_Oct_14_11_15_24_2025_315)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 13 Oct 2025 14:40:31 -0700, Masahiko Sawada wrote: > The patch refactors the CopyToStateData so that we can both hide > internal-use-only fields from extensions and extension can use its own > state data, while not adding extra indirection layers. TBH I'm really > not sure we must fully hide internal fields from extensions. Other > extendable components seem not to strictly hide internal information > from extensions. I'd suggest starting with only the latter point. That > is, we merge fields in CopyToStateInternalData to CopyToStateData. > What do you think? OK. Let's follow the existing style. How about the attached patch? It merges CopyToStateInternalData to CopyToStateData. Thanks, -- kou ----Next_Part(Tue_Oct_14_11_15_24_2025_315)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="0001-Split-CopyToStateData-to-CopyToState-Builtin-Data.patch"