Date: Tue, 14 Oct 2025 19:21:13 +0900 (JST)
Message-Id: <20251014.192113.1554227757626092006.ishii@postgresql.org>
To: li.evan.chao@gmail.com
Cc: tgl@sss.pgh.pa.us, pramsey@cleverelephant.ca, ojford@gmail.com,
 peter@eisentraut.org, krasiyan@gmail.com, vik@postgresfriends.org,
 andrew@tao11.riddles.org.uk, david@fetter.org,
 pgsql-hackers@lists.postgresql.org
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: <20251013.143941.1447453701514209859.ishii@postgresql.org>
References: <20251011.144218.1729318385118014326.ishii@postgresql.org>
	<66A28678-BDC0-4266-9244-74320D578222@gmail.com>
	<20251013.143941.1447453701514209859.ishii@postgresql.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20251014.192113.1554227757626092006.ishii%40postgresql.org>
Precedence: bulk

>>>> I overlooked the elog() call and "own implementation of
>>>> get_func_name()". Will fix.
>>> 
>>> Attached is a trivial patch to fix that. I am going to push it if
>>> there's no objection.
>>> 
>>> Best regards,
>>> --
>>> Tatsuo Ishii
>>> SRA OSS K.K.
>>> English: http://www.sraoss.co.jp/index_en/
>>> Japanese:http://www.sraoss.co.jp
>>> <v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>
>> 
>> 
>> I just take a quick look at the patch, a tiny comment is:
>> 
>> ```
>> +		char	   *funcname = get_func_name(fcinfo->flinfo->fn_oid);
>> ```
>> 
>> This can be a “const char *”.
> 
> Thanks for the review. In addition to the point, I added an assertion
> which is called by all other window function API. Also added check to
> the return value of get_func_name() because it could return NULL. V2
> patch attached.

V2 patch pushed. Thanks.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp