Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vAh3G-0055PQ-30 for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Oct 2025 03:59:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1vAh3D-00E3pb-7n for pgsql-hackers@arkaria.postgresql.org; Mon, 20 Oct 2025 03:59:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vAh3C-00E3pS-UT for pgsql-hackers@lists.postgresql.org; Mon, 20 Oct 2025 03:59:13 +0000 Received: from meldrar.postgresql.org ([2a02:c0:301:0:ffff::31]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vAh39-002ig5-2q for pgsql-hackers@lists.postgresql.org; Mon, 20 Oct 2025 03:59:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=postgresql.org; s=20171124; h=Content-Transfer-Encoding:Content-Type: Mime-Version:References:In-Reply-To:From:Subject:Cc:To:Message-Id:Date:Sender :Reply-To:Content-ID:Content-Description; bh=DIz0DRRLqnQbHL5YuluvoQqCm5Z8CAV5FzuyVY39qgM=; b=BkPjsyWLRX1QZjth/5JIzZhsQ8 n5MF3Uzcd5Lwo7X3ErpvJ8EGDwhTuKxZMRCKFW+9mGeWiJQnfwpuLuqo7ATHZ+JPst1rVMuHKjhs/ mwXaDFzSbeNlEX1ul61GmnC0kF4QFLfxdA/HPzKygVMWYGhbEd8EpZBNbXghtK8kOhuDH+mX+TxIS y8DlKsYqBL5n6OSNifxwy7ntD0byz9F+Iz47lX8MbqUY0G7nv7WT0gl0kjomQo3VztyEMpEx0wwA8 5TIQKTo4kQQjpuJLrv8KrN6HAnWCfQ4meVvnraLAajQikaKaGsgIbX3uFsjSd+Vbo4s58SsoTY8Wy h4W4pM9A==; Received: from [2409:11:4120:300:cfc1:614b:8801:dd54] (helo=localhost) by meldrar.postgresql.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vAh36-007h06-1v; Mon, 20 Oct 2025 03:59:10 +0000 Date: Mon, 20 Oct 2025 12:58:47 +0900 (JST) Message-Id: <20251020.125847.997839131426057290.ishii@postgresql.org> To: li.evan.chao@gmail.com Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, pramsey@cleverelephant.ca, ojford@gmail.com, peter@eisentraut.org, krasiyan@gmail.com, vik@postgresfriends.org, andrew@tao11.riddles.org.uk, david@fetter.org Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options From: Tatsuo Ishii In-Reply-To: References: <20251013.134332.1917267590891336373.ishii@postgresql.org> <20251019.185323.1616138750375579950.ishii@postgresql.org> X-Mailer: Mew version 6.8 on Emacs 29.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2409:11:4120:300:cfc1:614b:8801:dd54 (failed) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > A very trivial commit: > > ``` > + else > + > + /* > + * For other cases we have no idea what position of row callers would > + * fetch next time. Also for relpos < 0 case (we go backward), we > + * cannot set mark either. For those cases we always set mark at 0. > + */ > + mark_pos = 0; > ``` > > The empty line after “else” is not needed. That was added by pgindent. Best regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp