Feedback-ID: ie3de48e3:Fastmail
Date: Mon, 3 Nov 2025 18:44:31 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Daniel Verite <daniel@manitou-mail.org>, Tom Lane <tgl@sss.pgh.pa.us>
Subject: psql --help=variables missing csv_fieldsep
Message-ID: <202511031738.eqaeaedpx5cr@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="xu65muiv3v2h3nct"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/202511031738.eqaeaedpx5cr%40alvherre.pgsql>
Precedence: bulk


--xu65muiv3v2h3nct
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

While messing with the \pset boolean display patch, I noticed that psql
--help=variables is missing csv_fieldsep.  Is there a reason for this?
It appears to be an omission of commit aa2ba50c2c13 -- accidental?

The attached patch adds it.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.

--xu65muiv3v2h3nct
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Have-psql-s-variables-show-csv_fieldsep.patch"

From 2c452061b1e1388a7127fb7fd407c949aa6bec20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=81lvaro=20Herrera?= <alvherre@kurilemu.de>
Date: Mon, 3 Nov 2025 18:37:29 +0100
Subject: [PATCH] Have psql's "\? variables" show csv_fieldsep

The omission is unexplained.
---
 src/bin/psql/help.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/bin/psql/help.c b/src/bin/psql/help.c
index 6ae1a9940de..b635aa7dc57 100644
--- a/src/bin/psql/help.c
+++ b/src/bin/psql/help.c
@@ -480,6 +480,9 @@ helpVariables(unsigned short int pager)
 		  "    border style (number)\n");
 	HELP0("  columns\n"
 		  "    target width for the wrapped format\n");
+	HELPN("  csv_fieldsep\n"
+		  "    field separator to be used in CSV output format (default \"%c\")\n",
+		  DEFAULT_CSV_FIELD_SEP);
 	HELP0("  display_false\n"
 		  "    set the string to be printed in place of a boolean 'false'\n");
 	HELP0("  display_true\n"
-- 
2.47.3


--xu65muiv3v2h3nct--