Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLfj5-006iwV-20 for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Nov 2025 10:47:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vLfj2-00CEU6-3A for pgsql-hackers@arkaria.postgresql.org; Wed, 19 Nov 2025 10:47:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vLfj2-00CETx-1U for pgsql-hackers@lists.postgresql.org; Wed, 19 Nov 2025 10:47:49 +0000 Received: from fout-a6-smtp.messagingengine.com ([103.168.172.149]) by makus.postgresql.org with smtp (Exim 4.96) (envelope-from ) id 1vLfj0-000K7s-03 for pgsql-hackers@postgresql.org; Wed, 19 Nov 2025 10:47:47 +0000 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfout.phl.internal (Postfix) with ESMTP id 7D22EEC0184; Wed, 19 Nov 2025 05:47:45 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Wed, 19 Nov 2025 05:47:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1763549265; x= 1763635665; bh=FH1k66bX13FleFIdZN+LcbwbjGV6EVzrZiJMI09vDcU=; b=X aRnA8gbPNaYUJ/IdC89WRGooA52CDXCYf6CVgGcK2uilORDOZZx/pjGswSCsmLal FIEG3R5pDGROAB6LCTi13DOmkQbY7wrU7tjvSz+hksXCKI07ikTGGeak06kL3KuV 8zmEumXfg0oYxOMd7yGrPq0FcPenoGPCeaGALTHci+9Zedznp363THH1BuHWlv0E 5dxBOLe9/s8yBe+eUsvCKusUpNrTcU+HzUJh/JA8sFJZXJPjsBxRhymZSAuV46Ki t65FETzX2Z3FAEXrY91IqBcrwnLpEMnMo0rI6w79fG7+FMtp/ic9UkN+eejM3UuY +vL+tgLh1+kqLEh3wmuAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1763549265; x=1763635665; bh=F H1k66bX13FleFIdZN+LcbwbjGV6EVzrZiJMI09vDcU=; b=xOrCxdyV3IJpFMN53 8zSNUtXmekVxhRM8tm6uDyf8YvMk7uxk82HVeNxFY5drXonMCd8uVJOl6klb6EOo zNTujzWy5VVHt3K3olBTt/oHt/W9g+vQ58SFPXsUknZOOBudt1RlGAOkWtz9QbB2 1rjgekXuG/7zZKY0UpwUcsOTy78t4iktyMgXpUKmUKkzNoJQ/R8MVio5MiQ1xnkV +h4026HoVCHumGERX//YnioCftsw7QCF8Lo+8px26PV7UyEGdn3kF2KhXlSw7zAU i0Wl9l5WgXDe+tDqEiOsrvLTccX6ifNSzqopkjvtXQEXiB8YR/m2thNVI8OF5+Mn mpZfQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvdegtddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopegrkhhshhgrhidrjhhoshhhihesvghnthgvrhhprhhishgvuggs rdgtohhmpdhrtghpthhtoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpd hrtghpthhtohepjhgrphhinhhliheshhhothhmrghilhdrtghomhdprhgtphhtthhopehp ghhsqhhlqdhhrggtkhgvrhhssehpohhsthhgrhgvshhqlhdrohhrghdprhgtphhtthhope hquhgrnhiiohhnghhlihgrnhhgseihvggrhhdrnhgvth X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Nov 2025 05:47:44 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1763549263; bh=vBTlPIl2UcNS3BMsLUX05aYfnC90ZKi2oVgeQ5A0gpU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=XaKIjwZsoWqObPoyWmLc2UH7yeTEKYJk/+1IkTD8j3DZNcK/Yri/mLynWkKljMNbn jZTQgGKgR7UD2bKau5KHHMj5O0OnNvAivs4VZ6DWzUtMYOfD+JEouXfPSpmWkavnES pDX2oe4pv5ml3fEBraJNGaE2JdHOoMpDDz2R7EGYFrUt/ADG2RLOzegvhLbfHN7COa P6bZiS4Jib+cB2tmYiLxUkOTeya/iURe8a75UgVq0b1HE6TD8LK+qOYtq0KzsW8ltj 0P6etYV2Ogus1q1FPj128Jtx1v3Cv7UQJBUwFQjpofqtAIHDWhOg1hPIy8eXV+WFK8 eO2sZ0Nuq8+gA== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 9A64476; Wed, 19 Nov 2025 11:47:43 +0100 (CET) Date: Wed, 19 Nov 2025 11:47:43 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Akshay Joshi Cc: Chao Li , Japin Li , Quan Zongliang , pgsql-hackers Subject: Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement Message-ID: <202511191045.tckydhpoxumx@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hello, One thing I realized a few days ago is that since commit bd09f024a1bb we have type regdatabase, so instead of having two functions (one taking name and one taking Oid), we should have just one, taking regdatabase, just like the functions for producing DDL for other object types that have corresponding reg* type. Regards, -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/