Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 19 Nov 2025 23:03:59 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Michael Paquier <michael@paquier.xyz>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
 Quan Zongliang <quanzongliang@yeah.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro
Message-ID: <202511192201.3wvvrchnvyfb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmoaYY8nEmEgabLjQdUfqThQH4BYcBScv_SRkx-OsFukV=g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202511192201.3wvvrchnvyfb%40alvherre.pgsql>
Precedence: bulk

On 2025-Nov-19, Robert Haas wrote:

> I do not know how to make the phrase "older minor releases" any more
> clear.

It's perfectly clear.  I just don't believe this claim.

> You and Álvaro seem to be under the impression that nobody will
> ever try to compile code written after this change from a point
> release that we shipped before this change. While I don't think that
> will be a common thing to do, I'm not sure where you get the idea that
> older minor releases completely cease to be relevant when we release a
> new one. That's just not how it works.

I'm sure compiled versions continue to be relevant, but I highly doubt
anybody compiles afresh with old minors.

> I bet if we look in a few years we'll find modules on PGXN that have
> #ifdef logic in them to make sure they can work with both
> XLogRecPtrIsInvalid and XLogRecPtrIsValid.

Ok, let's wait a few years and see.  My bet is you won't find any.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/