Feedback-ID: ie3de48e3:Fastmail
Date: Sun, 23 Nov 2025 13:14:37 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Michael Paquier <michael@paquier.xyz>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Noah Misch <noah@leadboat.com>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY
Message-ID: <202511231211.kgqkbfb47ro6@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aSJEgABrlp7CyBJQ@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/202511231211.kgqkbfb47ro6%40alvherre.pgsql>
Precedence: bulk

On 2025-Nov-23, Michael Paquier wrote:

> On Sat, Nov 22, 2025 at 03:16:44PM +0100, Alvaro Herrera wrote:
> >         ExecDropSingleTupleTableSlot(existing_slot);
> > +       INJECTION_POINT("check-exclusion-or-unique-constraint-no-conflict", &conflict);
> > 
> > However, I don't see that the SQL injection point interface has the
> > ability to receive arguments, so I'm guessing that this is not workable?
> > Maybe something to consider for the future.
> 
> Are you referring to something like 371f2db8b05e here?  This has been
> added in 18.

Yes, exactly that ... but can this be used by the SQL injection points
functionality?  The test is an isolation .spec file, and I didn't find a
way to say "make me sleep when I hit this injection point, but only if
conflict is false".  Or maybe I just missed it.

Thanks!

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Estoy de acuerdo contigo en que la verdad absoluta no existe...
El problema es que la mentira sí existe y tu estás mintiendo" (G. Lama)