Feedback-ID: ie3de48e3:Fastmail
Date: Thu, 4 Dec 2025 12:21:15 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
	Peter Eisentraut <peter@eisentraut.org>,
 Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Cleanup shadows variable warnings, round 1
Message-ID: <202512041120.t3l7vzgdlzhj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAEoWx2mgTMAvXDi0AZVMeKys0owGa5tdQUJ0gonAjsdBOYMNkg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202512041120.t3l7vzgdlzhj%40alvherre.pgsql>
Precedence: bulk

On 2025-Dec-04, Chao Li wrote:

> The motivation is that CF’s CI currently fails on shadow-variable warnings.
> If you touch a file like a.c, and that file already has a legacy shadowing
> issue, CI will still fail your patch even if your changes are correct. Then
> you’re forced to fix unrelated shadow-variable problems just to get a clean
> CI run. I’ve run into this myself, and it’s disruptive for both patch
> authors and reviewers.

Hmm, maybe that should be turned off.  It sounds seriously unhelpful.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)