Feedback-ID: ia2694551:Fastmail
Date: Tue, 9 Dec 2025 09:58:52 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Euler Taveira <euler@eulerto.com>
Cc: japin <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers@lists.postgresql.org, Chao Li <li.evan.chao@gmail.com>
Subject: Re: log_min_messages per backend type
Message-ID: <202512090853.hk6e6t56bq5z@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="grg2fqqi6tkdt5me"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <144f0f96-c6d3-4ad6-a236-00200513e2e0@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202512090853.hk6e6t56bq5z%40alvherre.pgsql>
Precedence: bulk


--grg2fqqi6tkdt5me
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hello

I noticed failures under Windows, and realized that the EXEC_BACKEND
case was busted.  That's easy to fix -- just assign MyBackendType in
SubPostmasterMain() as well.  With that fix I was still getting some
crashes in three test modules, and after some debugging it turned out
that if you have shared_preload_library with a background worker and use
%b in the log_line_prefix, you get a crash trying to expand a name that
hasn't been set up yet.  I figured we can use a constant string in that
case.  Better ideas for that string welcome.

So here's your v6 again with those fixes as 0003 -- let's see what CI
thinks of this.  I haven't looked at your doc changes yet.


BTW with %b in log_line_prefix, the log file looks ... interesting.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Before you were born your parents weren't as boring as they are now. They
got that way paying your bills, cleaning up your room and listening to you
tell them how idealistic you are."  -- Charles J. Sykes' advice to teenagers

--grg2fqqi6tkdt5me
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v7-0001-log_min_messages-per-process-type.patch"