Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU5Sl-00Gi8v-2n for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Dec 2025 15:53:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vU5Sj-008WM5-2i for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Dec 2025 15:53:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU5Sj-008WLw-1X for pgsql-hackers@lists.postgresql.org; Fri, 12 Dec 2025 15:53:46 +0000 Received: from fout-a5-smtp.messagingengine.com ([103.168.172.148]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vU5Sh-000NER-1p for pgsql-hackers@lists.postgresql.org; Fri, 12 Dec 2025 15:53:45 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfout.phl.internal (Postfix) with ESMTP id 32DE0EC05A3; Fri, 12 Dec 2025 10:53:42 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Fri, 12 Dec 2025 10:53:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1765554822; x= 1765641222; bh=jvHyslKl8WR7xOwCsc0Q24sRsFpLPZU8oB+PjhTqNdw=; b=Y gj1shIIHy1SsiGby0zUrHhP0Mho0aHvXt1gW3DHeITxr1gOWbE4G8jSTn2MSnOnj +gkEwN8cyv34wyknvjJOT4BSm+6mbHcICnWTpSU4eiw4fAzOuz75Mdjx0/DjQ+nW ScMeV/irp4+onxKXxy0LIrp7UFVOvMdgVXYgwhlDHPYzK12xggsAykPNMbUZJ8k6 J6WPD6eZa8mFFP+AB7VNPJTHdnvhaJjfPb6kL2KXrvcqgyrfEA3HKN3pXaTUmHHH DoXyaeQ7KFXaTHAEel2t+Oa3I1ZNFEzuBwVE2eedIOONAYCZRR3nl0Winl/boQQT HkEutCqSteaFVXT3Iduiw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1765554822; x=1765641222; bh=j vHyslKl8WR7xOwCsc0Q24sRsFpLPZU8oB+PjhTqNdw=; b=bkUQNVzq53eOlY0K5 z866KupM3dIlSramo3c8NKuZRgvOldVqV3kEwKIXiPRcvZ0RHpV7paxdwQcaEGbM LqHl3b5pM9ToAkcp7qkG/rzm8K7lYbMOpHkwKKCHMwYTFPJpnLNi7r888MWLW0qm jRp6DvIK/0+uDr1O5+w2DIftTX2UP3rPHvvhJnroYUaQRPbx0GIw3rPyAPQRk22O ldpahRsZ3/cliQmmJOvvyGPp2WDkkfcxeNMwaCHJComNRbVEhxxQwiURiX1lue/X ruiHy25YDO7m6fCQ9gVo/qzwCCOGl95TW6vHtdZdNnmKD7MyF/l4MNtjQESVMQfV UlH2w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvkeehkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpemllhhvrghrohcu jfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhurdguvgeqnecuggftrf grthhtvghrnhepteeuvdehffekvefgueehveetveekgfegtddtueefueehuddutdfhfeff hfejfeffnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouh htpdhrtghpthhtoheprghrshgvnhhihidrmhhukhhhihhnrdguvghvsehgmhgrihhlrdgt ohhmpdhrtghpthhtoheplhhirdgvvhgrnhdrtghhrghosehgmhgrihhlrdgtohhmpdhrtg hpthhtohepnhgrthhhrghnuggsohhsshgrrhhtsehgmhgrihhlrdgtohhmpdhrtghpthht ohepphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorh hgpdhrtghpthhtohepsghruhgtvgesmhhomhhjihgrnhdruhhspdhrtghpthhtohepmhhi tghhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopegrlhgvkhhsrghnuggvrh esthhighgvrhgurghtrgdrtghomh X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Dec 2025 10:53:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1765554820; bh=sWniec3lgNfr71g9lifJx3Fv45Dbsivjx/mxtbDnPkc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=u1ngM1MdhDmjvc1ao0K19TrwCqz94tkF4TkPFi2lIM5Grq6dv2zJ1AupVslIhwGBq a+i/5SbtN1VzLuNynBSJLsjxlYXxuCG7sRrhG91kxSG/dquOKuTnG2PfW24hHY33SO V5qDRTs3MwWYd3hqtbCubLSHnD8IOJHN/NrgeODm3aWUCvMITHpR12eLz4o/c5vjbq tvU704hb2UYUtCx7OO7MWreW4FeceU+BLkbFSnCI0ONbLNvCRtho4Wq6rYSeqOUqc8 LChlPYMm6EoHIJoVuqC69spYAlUDp1Kr0cv68Novzc6bDQVynN15rSE0YVr4BtW93l u/AbGybp3p74Q== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 0414578; Fri, 12 Dec 2025 16:53:39 +0100 (CET) Date: Fri, 12 Dec 2025 16:53:39 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Aleksander Alekseev Cc: PostgreSQL Hackers , Nathan Bossart , Chao Li , Arseniy Mukhin , Bruce Momjian , Michael Paquier Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments Message-ID: <202512121547.dwkzxcs56227@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk It's strange to see this thread go on about messing with the Perl script because we're too afraid of pg_bsd_indent. Maybe we should take ownership of that code -- improve its own indentation to our conventions, add comments, rename unclear variables, and so on until we have something we can work with, and fix these weird bugs and idiosincratic behaviors we don't like. I just found out this code dates back from 1976. We have a _huge_ regression test for it: our own source code repository. It's not like any breakage is going to go unnoticed. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Cómo ponemos nuestros dedos en la arcilla del otro. Eso es la amistad; jugar al alfarero y ver qué formas se pueden sacar del otro" (C. Halloway en La Feria de las Tinieblas, R. Bradbury)