Date: Tue, 16 Dec 2025 19:23:57 -0800
From: Noah Misch <noah@leadboat.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: Alexander Lakhin <exclusion@gmail.com>,
	Nitin Motiani <nitinmotiani@google.com>,
	Andres Freund <andres@anarazel.de>,
	Ilyasov Ian <ianilyasov@outlook.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Surya Poondla <s_poondla@apple.com>
Subject: Re: Inval reliability, especially for inplace updates
Message-ID: <20251217032357.32.nmisch@google.com>
References: <20241101233829.9f.nmisch@google.com>
 <20241103182925.93.nmisch@google.com>
 <20250510151423.c2.nmisch@google.com>
 <CA+renyU+LGLvCqS0=fHit-N1J-2=2_mPK97AQxvcfKm+F-DxJA@mail.gmail.com>
 <CA+renyWSo3WigOO68ydGCQmDdZGLvXFGP3mLGo03XN09AKtDig@mail.gmail.com>
 <20250824233927.89.nmisch@google.com>
 <CA+renyWCW+_2QvXERBQ+mna6ANwAVXXmHKCA-WzL04bZRsjoBA@mail.gmail.com>
 <20251205001902.7a.nmisch@google.com>
 <20251212002437.2f.nmisch@google.com>
 <CA+renyVbRfcVcgASk_JhWL-o-WmkD64z1EUVtpYEUORuXaZ_Jw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+renyVbRfcVcgASk_JhWL-o-WmkD64z1EUVtpYEUORuXaZ_Jw@mail.gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20251217032357.32.nmisch%40google.com>
Precedence: bulk

On Fri, Dec 12, 2025 at 09:48:48AM -0800, Paul A Jungwirth wrote:
> On Thu, Dec 11, 2025 at 4:24 PM Noah Misch <noah@leadboat.com> wrote:
> > On Thu, Dec 04, 2025 at 04:19:02PM -0800, Noah Misch wrote:
> > > Thanks for the review.
> >
> > > The attached version doesn't need a comprehensive re-review, but I'd
> > > particularly value hearing about any places where you find it's reducing
> > > comprehensibility rather than enhancing.
> >
> > I'd like to get this into the back branches well in advance of the 2026-02
> > releases, in case the buildfarm catches some defect at low probability.  If
> > there are no objections in the next week, I'll proceed that way.
> 
> I'm happy with these new comments. The explanation in
> heap_inplace_lock before calling CacheInvalidateHeapTupleInplace is a
> lot better I think. And removing the last param means there is less to
> think about.

I pushed the patch bundle to v17-v14.  Thanks for the reviews!  The
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dragonet&dt=2025-12-17%2001%3A34%3A36
"double free or corruption (!prev)" likely witnessed a defect in how I
back-patched this to v14.  I am looking into it.