Date: Thu, 18 Dec 2025 10:30:57 -0800
From: Noah Misch <noah@leadboat.com>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Paul A Jungwirth <pj@illuminatedcomputing.com>,
	Nitin Motiani <nitinmotiani@google.com>,
	Andres Freund <andres@anarazel.de>,
	Ilyasov Ian <ianilyasov@outlook.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Surya Poondla <s_poondla@apple.com>
Subject: Re: Inval reliability, especially for inplace updates
Message-ID: <20251218183057.e6.nmisch@google.com>
References: <20250510151423.c2.nmisch@google.com>
 <CA+renyU+LGLvCqS0=fHit-N1J-2=2_mPK97AQxvcfKm+F-DxJA@mail.gmail.com>
 <CA+renyWSo3WigOO68ydGCQmDdZGLvXFGP3mLGo03XN09AKtDig@mail.gmail.com>
 <20250824233927.89.nmisch@google.com>
 <CA+renyWCW+_2QvXERBQ+mna6ANwAVXXmHKCA-WzL04bZRsjoBA@mail.gmail.com>
 <20251205001902.7a.nmisch@google.com>
 <20251212002437.2f.nmisch@google.com>
 <CA+renyVbRfcVcgASk_JhWL-o-WmkD64z1EUVtpYEUORuXaZ_Jw@mail.gmail.com>
 <20251217032357.32.nmisch@google.com>
 <00a14619-cb6a-49c1-918f-a90badfedd10@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00a14619-cb6a-49c1-918f-a90badfedd10@gmail.com>
User-Agent: Mutt/2.2.12 (2023-09-09)
Archived-At: 
 <https://www.postgresql.org/message-id/20251218183057.e6.nmisch%40google.com>
Precedence: bulk

On Wed, Dec 17, 2025 at 07:00:00AM +0200, Alexander Lakhin wrote:
> 17.12.2025 05:23, Noah Misch wrote:
> > I pushed the patch bundle to v17-v14.  Thanks for the reviews!  The
> > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dragonet&dt=2025-12-17%2001%3A34%3A36
> > "double free or corruption (!prev)" likely witnessed a defect in how I
> > back-patched this to v14.  I am looking into it.
> 
> Thank you for working on this!
> 
> Regarding that failure, it's more or less known issue, not related to your
> commit:
> https://wiki.postgresql.org/wiki/Known_Buildfarm_Test_Failures#check-pg_upgrade_fails_on_LLVM-enabled_animals_due_to_double_free_or_corruption
> https://www.postgresql.org/message-id/flat/aPAl27_urHSODwRN%40paquier.xyz

Since v14 dragonet had never failed before, I was ready to assume it was new.
Thank you for highlighting the older issue.  I agree.

Other buildfarm failures have been either abi-compliance-check (expected) or
unrelated, so I've closed https://commitfest.postgresql.org/patch/5091/.  That
finishes the known-reachable inplace update corruption routes.