Feedback-ID: ie3de48e3:Fastmail
Date: Tue, 30 Dec 2025 00:14:42 -0300
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>,
	Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
	Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>,
	jian he <jian.universality@gmail.com>, Tomas Vondra <tomas@vondra.me>,
	Yura Sokolov <y.sokolov@postgrespro.ru>
Subject: Re: Implement waiting for wal lsn replay: reloaded
Message-ID: <202512300309.ob42gaafej7v@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CABPTF7WDzTs2EEB6c5QmsV-svF4rKSTLOS1pWM+7ydUN6tnFOQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202512300309.ob42gaafej7v%40alvherre.pgsql>
Precedence: bulk

On 2025-Dec-27, Xuneng Zhou wrote:

> On Fri, Dec 26, 2025 at 4:25 PM Chao Li <li.evan.chao@gmail.com> wrote:

> > 2 - 0002
> > ```
> > +                       else
> > +                               ereport(ERROR,
> > +                                               (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> > +                                                errmsg("unrecognized value for WAIT option \"%s\": \"%s\"",
> > +                                                               "MODE", mode_str),
> > ```
> >
> > I wonder why don’t we directly put MODE into the error message?
> 
> Yeah, putting MODE into the error message is cleaner. It's done in v8.

The reason not to do that (and also put WAIT in a separate string) is so
that the message is identicla to other messages and thus requires no
separate translation, specifically
  errmsg("unrecognized value for %s option \"%s\": \"%s\"", ...)

See commit 502e256f2262.  Please use that form.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El sabio habla porque tiene algo que decir;
el tonto, porque tiene que decir algo" (Platon).