Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfi2F-004LjL-2A for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 17:18:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vfi2E-005jwu-28 for pgsql-hackers@arkaria.postgresql.org; Tue, 13 Jan 2026 17:18:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfi2E-005jwm-0I for pgsql-hackers@lists.postgresql.org; Tue, 13 Jan 2026 17:18:26 +0000 Received: from fout-a4-smtp.messagingengine.com ([103.168.172.147]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vfi2B-000EoG-1y for pgsql-hackers@lists.postgresql.org; Tue, 13 Jan 2026 17:18:25 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfout.phl.internal (Postfix) with ESMTP id 85DEBEC0128; Tue, 13 Jan 2026 12:18:22 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 13 Jan 2026 12:18:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1768324702; x= 1768411102; bh=PpU/dPt4fxQNeciXmuIeWWBTKjvHMkmKU7zuNj2YovA=; b=f Ue+cmPO+egO6ASlxsZTOmwBK/EEsN0GvEvAUn/V+MmpdrOH9djCxnQ/fNvQhvaP2 uLXc5i2l2wfesgxALahUHuz5iYYXmtBJXtOugo+KoWHhcRwD+upceK0il4nwkHcO 9Kvo8Mz9LwFkShkVA+hRfjgnsSV6vhFBBqaykN/twaATe62BdD2bL46nqTVGhU8J StT2bwupGso2kMdh2TU9FoSi7JKx9ruZzFCOUDrh6ZuAywRjMkVf/lVJTvjDB8Gf zL9P4nw0DpaZGIbBxrPT5Btk90gsRHq1g6EJoCDY+S1zTtY2QGJ37lrsTBxeQ69O oWR14QuzrJdIuXxmvs9ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1768324702; x=1768411102; bh=P pU/dPt4fxQNeciXmuIeWWBTKjvHMkmKU7zuNj2YovA=; b=nTQN/qudp3APVkOGs 8bL9eGxr/5O9G4fl18QvebxiwtpVQ+rl1tZaBcL3+Y+rD8s5+v3HX4ZnoARzzvka xdaSs1ZKlDUX9IBmfR8YHzLAHZHbzrhPKKN9tQ/KOs8+121YGGzJXdmEBtzzi0KW Z6YgFXGcGx4GtqklkWSnRH7j6q1wanIZujZO83y9+Q3rivgnZzy3CHjiYcV7A3mf V/sOmejSdmi2GZsltTIUxeOAWV7k0B+ttGIN/Ki3+cQv/0eKA2Zl6z/c7gfApQqE e7Wq1T6DUSvQ/nhfcYBfvsrp9aDblYu/8FtvqwIEqnSjQQTVi3OJPUX8jd+nmumz i12dQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduvddtledtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfggtggugfgjsehtkeertd dttdejnecuhfhrohhmpemllhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvges khhurhhilhgvmhhurdguvgeqnecuggftrfgrthhtvghrnhepkefgkefhgffghedvgfdtvd dvieehveduiedtieehkeduhefgteetveektdefkeegnecuffhomhgrihhnpehpohhsthhg rhdrvghspdgvnhhtvghrphhrihhsvggusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgeskhhurhhilhgvmhhu rdguvgdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoh epphhgshhqlhdqhhgrtghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhg pdhrtghpthhtohepvddutdegfedvjedvsehqqhdrtghomh X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 13 Jan 2026 12:18:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1768324699; bh=yLmVooyjnid+WAIWNSb+cy7Kb4LasAdAiQpRIpLgpVk=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=h4N2hxp5xfNx6NsDmMDMOI+HF08Pt/RGpGjfS7NXUK4yKSzMyBHBVvJoEG2aGXFwT voNrNzSs+z5FVSSqpG5+nu7cF0un/ZC38NAXSxXMkqfYRL/2kLnmVCWYTax6BIGteN 59Pu6hRAkwLCLRu8YhyTeP1DyTcnJiqIt3z6hmRFqywINGRLb1zA+SLB1aVqiMTuG0 4/KYJxMr+Wps0mKv8svUvzSDLHJ/T4pw0/0/RZdEFBQKIUL/sGB3KYeseH30t5Tycr t/SlrjN6PZM16tS5ZluC0ihpE7Hsaz6M9Dm9gnZTnEfppx6xbI069f4tsfLn/52g1z GXIoOOoT2xXLw== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 923917A; Tue, 13 Jan 2026 18:18:19 +0100 (CET) Date: Tue, 13 Jan 2026 18:18:19 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: liujinyang <21043272@qq.com> Cc: pgsql-hackers Subject: Re: remove the unneeded header file math.h in binaryheap.c Message-ID: <202601131402.kjp7ceoxgr44@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-Jan-13, liujinyang wrote: > Hi Hackers, > > I found in file binaryheap.c， file "math.h" was included, but it is uncessary, so I removed it  > and filing a patch to address the issue. Fun. This was already unnecessary at commit 7a2fe9bd0371 which introduced the file. It seems Abhijit had that include in his first version [1] because he was using floor(). Robert rewrote it later [2] and replaced that with straight arithmetic, making the include unnecessary, but forgot to remove it. [1] https://postgr.es/m/20121114131112.GA27771@toroid.org [2] https://postgr.es/m/CA%2BTgmobvR7XW9fjj2RNY7sKK-VAG5nahfai_zV51rHVLDNvaBg%40mail.gmail.com -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/