Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viAyd-00HQeP-0l for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 12:36:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1viAyc-0019BJ-13 for pgsql-hackers@arkaria.postgresql.org; Tue, 20 Jan 2026 12:36:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viAyc-0019BB-05 for pgsql-hackers@lists.postgresql.org; Tue, 20 Jan 2026 12:36:54 +0000 Received: from fout-b1-smtp.messagingengine.com ([202.12.124.144]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1viAyZ-001WTX-2O for pgsql-hackers@lists.postgresql.org; Tue, 20 Jan 2026 12:36:54 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id A719A1D0042B; Tue, 20 Jan 2026 07:36:49 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 20 Jan 2026 07:36:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1768912609; x= 1768999009; bh=toSBt8z704Tpw9qcg55QdC5wNsOofTZho5nyaKP8m6U=; b=o 1t5hC9G4BaO7y+oViqfR5n16r4Vz4vanOj5tvtgekREgxGAfIyCjnc63Y2ZUZMfM 7Yron9rY2G8/wuyzjM4b52WhEsInS4joff17fSqm9Hc4jP7IYDjgcFQUHjidX/+y VhqL6o8ygt3o3xpzAgkU66SIAV3cQKeUWd8u81DgXToslHHPbc/76rYWV1RVUSfV yjc+HUhehVISO7gVYIwedeFQXjie9sY4CAbRCaOs6tvsSzLXTkF5KLfVHZ0EYf92 jaNUbrZQugqFmkKDNiQ37jWf/ZumcgcerFU4nU1/EV4hlQm9AJi/9JLqFVJxMBYj rICH+prvVIP6WTvjRIkwQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1768912609; x=1768999009; bh=t oSBt8z704Tpw9qcg55QdC5wNsOofTZho5nyaKP8m6U=; b=Yh97DHAXJvEDKabZx QzkpenR8yUnE8RtfN55/GBd7ADR2V3qP2CO2DPva8iOpat8FNK34zl1UANZpCxSV cwL6latrLrOiJ04/67EhV4RoShKcpNwCzkZ7UTu431eUBOHgAvzRwDBhs0u+cncO Pp/0V2JuSPet+oRqjRVSaLrbaYhHx/ZOYE62+3h0yUVu18OJuCzaR87ub3JmIzOR Wp5Zj77kphHdTM6u6YpXwkoa06qGL084DKW/BRrgz9pAP4VtVMHQddRIwgRt1w7y VLZmzHaPftMSpQU+9Ue85GfSHaYtZJEhcLTplGQbfykzZW0vRSNpxhF65HhNtZ/o roTlw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddugedtgeefucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhg rhgvshhqlhdrohhrghdprhgtphhtthhopehmihgthhgrvghlsehprghquhhivghrrdighi ii X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Jan 2026 07:36:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1768912607; bh=BmGT8gRDmWBEZUaQuBsNiX3lsg4JCOwepPOOVarzA9Q=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=JhYwvJtn2MtR5u+NLgJhqupwqYZE9txGou1myONgdk0wNC6998B7ZuWRUm0f9zpAS xcPewMC/dTjOVF3KtgguV7CtbATmZBMqM97Ne2pzFI+XRPLVzSaE17O9alBF5lpPoz tgi3BS4HWo5UKYxYr5tII3u7J5OH76qXZO4qkrqwpvO3190g+xhFHgUMWN0blHVh+O zMDIld5G88/nWuM1oCoCcCbmOvU2SvujPmLDcwh1tOX/X+P6+IKVBEfB2aeyCpQ1VX 4WQS9dZ47DU+IpYE9+h0UyimTLBxoCGEHsukPkv6iLi8yizRndWarmXjT9+JzrOal7 TvhJyqDAMqBiQ== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id C17A67A; Tue, 20 Jan 2026 13:36:47 +0100 (CET) Date: Tue, 20 Jan 2026 13:36:47 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Michael Paquier Cc: Postgres hackers Subject: Re: Some cleanup of pg_stat_statements tests Message-ID: <202601201236.phfzenkxh4qi@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-Jan-20, Michael Paquier wrote: > While looking at this area of the code, I have noticed that the new > "squashing" test is not consistent with the rest of the test suite, > re-creating the extension for nothing. > > The structure of the test is to have the "cleanup" phase second to > last, so as there is no need to create multiple times the extensions. Huh, yeah, agreed on this change. > In passing, I'd like to suggest that REGRESS in the Makefile uses one > item per line, to minimize diffs when we add new stuff. Absolutely. > Any thoughts or objections about the attached? No objections here. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Java is clearly an example of money oriented programming" (A. Stepanov)