Subject: Re: Some cleanup of pg_stat_statements tests

From: Álvaro Herrera <[email-masked]>
Date: Tue, 20 Jan 2026 13:36:47 +0100

On 2026-Jan-20, Michael Paquier wrote:

> While looking at this area of the code, I have noticed that the new
> "squashing" test is not consistent with the rest of the test suite,
> re-creating the extension for nothing.
> 
> The structure of the test is to have the "cleanup" phase second to
> last, so as there is no need to create multiple times the extensions.

Huh, yeah, agreed on this change.

> In passing, I'd like to suggest that REGRESS in the Makefile uses one
> item per line, to minimize diffs when we add new stuff.

Absolutely.

> Any thoughts or objections about the attached?

No objections here.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Java is clearly an example of money oriented programming"  (A. Stepanov)