Feedback-ID: ia2694551:Fastmail
Date: Tue, 20 Jan 2026 16:43:48 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Euler Taveira <euler@eulerto.com>
Cc: japin <japinli@hotmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers@lists.postgresql.org, Chao Li <li.evan.chao@gmail.com>
Subject: Re: log_min_messages per backend type
Message-ID: <202601201541.hbzj6ihp7ei4@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <603d4e3e-8aa1-485f-8f0c-3f48822fbf9c@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202601201541.hbzj6ihp7ei4%40alvherre.pgsql>
Precedence: bulk

On 2026-Jan-15, Euler Taveira wrote:

> On Tue, Dec 9, 2025, at 1:30 PM, Alvaro Herrera wrote:
> > BTW another thing I realized while looking this over, is that we quite
> > uselessly transform the integer backend type to a string, pass it as a
> > string using the --forkchild= argument to the child process, then parse
> > the string back to an int to use as an array index.  It would be much
> > easier to just use the integer value everywhere, as the attached shows.
> >
> 
> It is a good simplification.

Thanks!  Pushed.

> There is just one oversight.
> 
> +   child_type = (BackendType) atoi(child_kind);
> +   if (child_type <= B_INVALID || child_type > BACKEND_NUM_TYPES)
>         elog(ERROR, "unknown child kind %s", child_kind);
> 
> It should be BACKEND_NUM_TYPES - 1.

Good catch, thanks.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Digital and video cameras have this adjustment and film cameras don't for the
same reason dogs and cats lick themselves: because they can."   (Ken Rockwell)