Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlW52-0007yU-23 for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jan 2026 17:45:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vlW50-0005ja-2H for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jan 2026 17:45:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlW50-0005jQ-0T for pgsql-hackers@lists.postgresql.org; Thu, 29 Jan 2026 17:45:19 +0000 Received: from fhigh-a2-smtp.messagingengine.com ([103.168.172.153]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vlW4y-000000002WR-0JZA for pgsql-hackers@lists.postgresql.org; Thu, 29 Jan 2026 17:45:18 +0000 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4CEF314000F1; Thu, 29 Jan 2026 12:45:14 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Thu, 29 Jan 2026 12:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1769708714; x= 1769795114; bh=D9SjPMzrXy3bZMybyRCg+mMTgqFOQEFX+EKxofjsR2g=; b=S urg0HaM/Nw0mbNx4uKRr11mrR5gd+xg2kg4APAHmrLN1yeojM11yuCMAIw0uWY94 TxI/hFbFEfBBmC8cLLHA97VX0qmKViW2y8K5MbUi8IbuB3hHK1eWbwSIRr9cusjZ eFa5TohXqjTJL4AFsbl6G6NTOpaFDJBulTo01xErYTUsbcQirDSrszz+WEKyZdyt FWXAet87mRx4SpGEvIXnR1UH2qhkiHE+HsiDxm30mhCxsF936l+lNwJPZmRv1H9k aaBPJnvTcP9RTuN6ThuDUzYlWuA0/jFhM6MnPXdJltYgfpfERJEjO2kjaJzjIm6+ DmToYwGxsVHQxDnF1T/6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1769708714; x=1769795114; bh=D 9SjPMzrXy3bZMybyRCg+mMTgqFOQEFX+EKxofjsR2g=; b=CoWeVyIhplH517/Pl 7vvBFYcy+sZ7G88hKl2te0lVwkSwIOYD22n10z2OV7B+qfEw+kedhVvTIfk0KUqG 3+rsdeeIUFLWekLFoXpR4KRiBMHNDa/EkS5meA90efILOot/hHzFxqIXzn31Q/ym BZdvAxLK2+xQPblBStjUh8mygDCKhAzaKL2q8vAxkharNe6pHPIMLUpLONXRk7Ju WoxbQhTLkTutX9hOB1AC0hEjUqdbYX+7EsQoVR/1c35uz8ytVeCXJEPM9DDN/WoL BS6OYo5C8V5iJ/ot49dK7+9jhMrlfFo6SleC/9v6br9ak26gBB5GbYYhqFvJs4jE XjU/g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieeikedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdprhgtphht thhopegsvghrthhrrghnuggurhhouhhvohhtrdhpghesghhmrghilhdrtghomhdprhgtph htthhopehhlhhinhhnrghkrgesihhkihdrfhhipdhrtghpthhtohepphhgshhqlhdqhhgr tghkvghrsheslhhishhtshdrphhoshhtghhrvghsqhhlrdhorhhgpdhrtghpthhtohepmh hitghhrggvlhesphgrqhhuihgvrhdrgiihiidprhgtphhtthhopehquhgrnhiiohhnghhl ihgrnhhgseihvggrhhdrnhgvth X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 29 Jan 2026 12:45:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1769708712; bh=hj9Knh8BzVxlKMeRNZFSLrJa4voH9IxbOrE7iSJLUfY=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=nsl30/f0UcEY/2aXp1aI5qM5jcwQRn9S69teAGbuXlYIP5WqRsjpqhXcncrAgWy/Z 944IZUETjUM1UZF2D7uegVXv0SD2qIBv7bznA70QAfNmN+dJy77uUee3k1JT4lR390 3K4cTxTbkh/7mSoOTJZQ01wJgYHBmH+xIj0typk5SxVzi+UStZTE6ukVv94pJ0+ELn DPwnbjpxlFlyh5K5Voas7R8pBfXidlbZymYB3E4C2F0zIctljvYBEiuLNTeBc2AgtG BiEEX/IsIluk4jK/vsBxboOw/SnY1YLSfwzR1yvtWeah0yQlTDIZ9y1tp4XJbFUIIG VMeyfRGy5Oesw== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 7FAF86A; Thu, 29 Jan 2026 18:45:12 +0100 (CET) Date: Thu, 29 Jan 2026 18:45:12 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Bertrand Drouvot Cc: Peter Eisentraut , Michael Paquier , Heikki Linnakangas , Quan Zongliang , pgsql-hackers@lists.postgresql.org Subject: Re: Consistently use the XLogRecPtrIsInvalid() macro Message-ID: <202601291744.chmxe2jjofs6@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2025-Nov-17, Bertrand Drouvot wrote: > On Mon, Nov 17, 2025 at 01:12:24PM +0000, Bertrand Drouvot wrote: > > The script has been updated and the patch too (finding a new replacement in > > gist.c). > > Finally, adding GistNSN to the game (as a typedef XLogRecPtr) gives the attached. I've pushed this. Hopefully it won't upset anything. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/ Officer Krupke, what are we to do? Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke")