Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlknR-003Y1s-3A for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Jan 2026 09:28:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vlknP-0044MF-2p for pgsql-hackers@arkaria.postgresql.org; Fri, 30 Jan 2026 09:28:08 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlknP-0044M7-0J for pgsql-hackers@lists.postgresql.org; Fri, 30 Jan 2026 09:28:08 +0000 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vlknN-0008d5-1L for pgsql-hackers@lists.postgresql.org; Fri, 30 Jan 2026 09:28:07 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.stl.internal (Postfix) with ESMTP id CC06B7A00CB; Fri, 30 Jan 2026 04:28:04 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Fri, 30 Jan 2026 04:28:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm1; t=1769765284; x= 1769851684; bh=iV+V4Jpfcu2HCoaHdJReBC+m+qyfAEaE1UTFSprVey4=; b=Y +uM+b1MsP6rZuzj+Yzvit6IIBiBmzGpqwQu7admA9VP5HV5jKRB4ylnRn69dfXdS /UAefRq0gGUNxLXFaIwjJGIMzZyDV/RUABo3jzdxYN3BNNjzJwFVngSCen7HyJWS IhfPjCduQW9CKqga5qcK61RXnjLqyfGVtHIH9HsTEOmUIMv1YiVZzZBQTtLTd2IE cLodj0RaQ6Zg0UpPzSaQ6kgP9z1Y+R6T45uvo6hn+VwpmRPbaXNjZN9U1u2OjIj7 7e2qVqLVRElatB8senC8qX9wJMAxcvCkx5ebjQLDqv7rvyla5uHb8GErxplouKZu fTccsEU9e/Qz19TtJp3Mw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1769765284; x=1769851684; bh=i V+V4Jpfcu2HCoaHdJReBC+m+qyfAEaE1UTFSprVey4=; b=TAOGd6QR9XFFS4UHA VhND0GneocsvOXkQgcEY4rmBch/pz0DKvvFNB8b45z0TTa9cU86b1lx1Jn+dJAYf /qRiQ1gBZ3TrUVsOnnmew+KrTefnL2FKipDj7W+vz33EdRHztOwlDI0wsCeKq+in 9okWlEFQG33Ts+jH5z8Fy/9LXtvgE7SmmDI0l0PQ335fjk5PXjwJSf2j6iUyDoc1 4LJHcLjyReBKXtCAe3Qjp2NGP0jyIJ2KYdG7xyJOYA7CMY48iu7r3SO3b5uYs5rm uu6lblI5hnU7fFRHhAiJyNAy30Mqt17WrO4PELji+rlewv9+SzeGOdicq1dSwBR9 thP4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieekieekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehpvghtvghrsegvihhsvghnthhrrghuthdrohhrghdprhgtphht thhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvshhqlhdroh hrgh X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jan 2026 04:28:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1769765282; bh=adjJVhHtdJjsQhALkFwaVBUvYJpQu/yUQ2b+B43tDIQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ht4YjBsqkZL5bqp7RNhm+/cGmHUGX2WFzIHmi5MQlOIMNwFa6VY1TlKq8lYApDWVc fPvtLAvWdW6FjanmHguT08paqRjSVpxI2g4XvC9t3tvm0WWCy9Uul1qp150wDLs506 Kj3xbbqYbDNxugA0Mt47SOHiBVEhdFCKqe6pifTFgh9zX8ZcTZ0Stp6Oj6rfIPpFas a8qXu8vsOenyvwCPEmQfu+ir2ga7z/NH6FhfaORSeHInrEUVShNoxaa60D0s2KAN4/ KLQGz5w8YpvaksMqGSbqwCIgctv+4ji8D4tSQLiIvFx24zqO+UI23aC88rw7fkFJ0c g/MSlkRqIwiMg== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id B27D86A; Fri, 30 Jan 2026 10:28:02 +0100 (CET) Date: Fri, 30 Jan 2026 10:28:02 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Peter Eisentraut Cc: Pg Hackers Subject: Re: trivial designated initializers Message-ID: <202601300912.ccxqnxxcl72r@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2026-Jan-29, Peter Eisentraut wrote: > You could spruce this up further like > > [LockTupleKeyShare] = { > .hwlock = AccessShareLock, > ... > }, Oh right, done that way. > The comments "/* KeyShare does not allow updating tuples */" etc. seem > repetitive and don't actually explain why -1 is an appropriate value. You > could instead write a comment by the declaration of the updstatus field, > like "set to -1 if the tuple lock mode does not allow updating tuples (see > get_mxact_status_for_lock())". Good point. I rewrote the comment on top of the declaration and pushed, thanks for the reviews. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "Hay dos momentos en la vida de un hombre en los que no debería especular: cuando puede permitírselo y cuando no puede" (Mark Twain)