Feedback-ID: ie3de48e3:Fastmail
Date: Sat, 31 Jan 2026 16:08:38 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: splitting pg_resetwal output strings
Message-ID: <202601311502.ohp4cx7hfms2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="m4rixdodkhrlzpzv"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202601310924.yoik5n3blgt4@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/202601311502.ohp4cx7hfms2%40alvherre.pgsql>
Precedence: bulk


--m4rixdodkhrlzpzv
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2026-Jan-31, Álvaro Herrera wrote:

> This is not complete.  It modifies PrintControlValues(), which is easy
> because I just print each item in the entries.h file in the same order
> they appear there.   But for PrintNewControlValues() I'll need to add a
> symbolic identifier to each string, that the code can use to scan the
> array and print just those elements.  I'll do that if there are no
> objections to this idea here.

It looks more or less like this.  Patch 0001 is the same as before, and
0002 adds the symbolic names, which is used to create an enum and then
to search for the correct lines to print in PrintNewControlValues.

I decided to reuse simple_oid_list to store the integers values, which
is kinda icky, so getting to something committable I think would have me
add simple_int_list.  Also, there's a few blocks that are duplicate
cases of the same line measuring and printing logic; I suppose I should
have a routine to simplify.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Most hackers will be perfectly comfortable conceptualizing users as entropy
 sources, so let's move on."                               (Nathaniel Smith)
      https://mail.gnu.org/archive/html/monotone-devel/2007-01/msg00080.html

--m4rixdodkhrlzpzv
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-Split-out-entry-names-in-pg_resetwal.patch"