Feedback-ID: ia2694551:Fastmail
Date: Mon, 2 Feb 2026 11:54:34 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, 
	Mahendra Singh Thalor <mahi6run@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, 
	Srinath Reddy <srinath2133@gmail.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: getting "shell command argument contains a newline or carriage
 return:" error with pg_dumpall when db name have new line in double quote
Message-ID: <202602021048.m5lsx277xfuw@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1235912.1769703839@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/202602021048.m5lsx277xfuw%40alvherre.pgsql>
Precedence: bulk

Hello,

This is not an objection to this patch, but I don't see why we should
allow newlines in tablespace names if we're going to restrict them in
names of roles and databases.  Is it only because pg_dumpall happens not
to dump a comment with the tablespace name on it, like we do for dbs and
roles?  Sounds unprincipled.

I think keeping these things under the same rules makes the most sense.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"The problem with the facetime model is not just that it's demoralizing, but
that the people pretending to work interrupt the ones actually working."
                  -- Paul Graham, http://www.paulgraham.com/opensource.html