public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Wed, 04 Feb 2026 09:04:51 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAAe_zDtstKUcKsH3FJuKeZ=ykXFWKO1Lz80JXEn9y8BeQeYNQ@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAAAe_zDtstKUcKsH3FJuKeZ=ykXFWKO1Lz80JXEn9y8BeQeYNQ@mail.gmail.com>

> Thank you for catching this! You are absolutely right. I apologize for
> using non-ASCII characters in the code comments.
> 
> I've reviewed all the RPR-related files and found additional instances
> of non-ASCII characters:
> - Arrows "→" instead of "->"
> - Superscript "²" instead of "^2"
> - Greater-than-or-equal "≥" instead of ">="
> 
> Found in:
> - src/backend/optimizer/plan/rpr.c (1 instance)
> - src/backend/executor/nodeWindowAgg.c (5 instances)
> - src/include/nodes/execnodes.h (4 instances)
> - src/test/regress/sql/rpr.sql (7 instances)
> - src/test/regress/sql/rpr_base.sql (15 instances)
> - src/test/regress/expected/rpr.out (7 instances)
> - src/test/regress/expected/rpr_base.out (15 instances)
> 
> Total: 54 instances across 7 files.
> 
> To ensure comprehensive coverage, I created a Python verification tool
> that checks for non-ASCII characters and reports their Unicode code
> points. I've verified all 46 files changed in the v42 patch series,
> and confirmed no additional non-ASCII characters remain.
> 
> I'll be more careful going forward to use only ASCII characters in
> source files and comments. Updated patch attached.

Thank you for the prompt response. Your patch applied cleanly here.
BTW, I have a question regarding NFA related objects initialization in
nodeWindowAgg.c.

In release_partition():
	/* Reset NFA state for new partition */
	winstate->nfaContext = NULL;
	winstate->nfaContextTail = NULL;
	winstate->nfaContextFree = NULL;
	winstate->nfaStateFree = NULL;
	winstate->nfaLastProcessedRow = -1;
	winstate->nfaStatesActive = 0;
	winstate->nfaContextsActive = 0;

While in ExecInitWindowAgg():
	/* Initialize NFA free lists for row pattern matching */
	winstate->nfaContext = NULL;
	winstate->nfaContextTail = NULL;
	winstate->nfaContextFree = NULL;
	winstate->nfaStateFree = NULL;
	winstate->nfaLastProcessedRow = -1;

So the latter does not initialize winstate->nfaStatesActive and
winstate->nfaContextsActive. Can you please explain why?
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox