public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 1/3] bootstrap: convert Typ to a List*
4+ messages / 4 participants
[nested] [flat]
* [PATCH 1/3] bootstrap: convert Typ to a List*
@ 2020-11-20 02:48 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Justin Pryzby @ 2020-11-20 02:48 UTC (permalink / raw)
---
src/backend/bootstrap/bootstrap.c | 69 ++++++++++++++-----------------
1 file changed, 31 insertions(+), 38 deletions(-)
diff --git a/src/backend/bootstrap/bootstrap.c b/src/backend/bootstrap/bootstrap.c
index 6f615e6622..18eb62ca47 100644
--- a/src/backend/bootstrap/bootstrap.c
+++ b/src/backend/bootstrap/bootstrap.c
@@ -159,7 +159,7 @@ struct typmap
FormData_pg_type am_typ;
};
-static struct typmap **Typ = NULL;
+static List *Typ = NIL; /* List of struct typmap* */
static struct typmap *Ap = NULL;
static Datum values[MAXATTR]; /* current row's attribute values */
@@ -597,7 +597,7 @@ boot_openrel(char *relname)
* pg_type must be filled before any OPEN command is executed, hence we
* can now populate the Typ array if we haven't yet.
*/
- if (Typ == NULL)
+ if (Typ == NIL)
populate_typ_array();
if (boot_reldesc != NULL)
@@ -688,7 +688,7 @@ DefineAttr(char *name, char *type, int attnum, int nullness)
typeoid = gettype(type);
- if (Typ != NULL)
+ if (Typ != NIL)
{
attrtypes[attnum]->atttypid = Ap->am_oid;
attrtypes[attnum]->attlen = Ap->am_typ.typlen;
@@ -877,36 +877,25 @@ populate_typ_array(void)
Relation rel;
TableScanDesc scan;
HeapTuple tup;
- int nalloc;
- int i;
-
- Assert(Typ == NULL);
- nalloc = 512;
- Typ = (struct typmap **)
- MemoryContextAlloc(TopMemoryContext, nalloc * sizeof(struct typmap *));
+ Assert(Typ == NIL);
rel = table_open(TypeRelationId, NoLock);
scan = table_beginscan_catalog(rel, 0, NULL);
- i = 0;
while ((tup = heap_getnext(scan, ForwardScanDirection)) != NULL)
{
Form_pg_type typForm = (Form_pg_type) GETSTRUCT(tup);
+ struct typmap *newtyp;
+ MemoryContext old;
- /* make sure there will be room for a trailing NULL pointer */
- if (i >= nalloc - 1)
- {
- nalloc *= 2;
- Typ = (struct typmap **)
- repalloc(Typ, nalloc * sizeof(struct typmap *));
- }
- Typ[i] = (struct typmap *)
- MemoryContextAlloc(TopMemoryContext, sizeof(struct typmap));
- Typ[i]->am_oid = typForm->oid;
- memcpy(&(Typ[i]->am_typ), typForm, sizeof(Typ[i]->am_typ));
- i++;
+ old = MemoryContextSwitchTo(TopMemoryContext);
+ newtyp = (struct typmap *) palloc(sizeof(struct typmap));
+ Typ = lappend(Typ, newtyp);
+ MemoryContextSwitchTo(old);
+
+ newtyp->am_oid = typForm->oid;
+ memcpy(&newtyp->am_typ, typForm, sizeof(newtyp->am_typ));
}
- Typ[i] = NULL; /* Fill trailing NULL pointer */
table_endscan(scan);
table_close(rel, NoLock);
}
@@ -925,16 +914,17 @@ populate_typ_array(void)
static Oid
gettype(char *type)
{
- if (Typ != NULL)
+ if (Typ != NIL)
{
- struct typmap **app;
+ ListCell *lc;
- for (app = Typ; *app != NULL; app++)
+ foreach (lc, Typ)
{
- if (strncmp(NameStr((*app)->am_typ.typname), type, NAMEDATALEN) == 0)
+ struct typmap *app = lfirst(lc);
+ if (strncmp(NameStr(app->am_typ.typname), type, NAMEDATALEN) == 0)
{
- Ap = *app;
- return (*app)->am_oid;
+ Ap = app;
+ return app->am_oid;
}
}
}
@@ -980,14 +970,17 @@ boot_get_type_io_data(Oid typid,
if (Typ != NULL)
{
/* We have the boot-time contents of pg_type, so use it */
- struct typmap **app;
- struct typmap *ap;
-
- app = Typ;
- while (*app && (*app)->am_oid != typid)
- ++app;
- ap = *app;
- if (ap == NULL)
+ struct typmap *ap = NULL;
+ ListCell *lc;
+
+ foreach (lc, Typ)
+ {
+ ap = lfirst(lc);
+ if (ap->am_oid == typid)
+ break;
+ }
+
+ if (!ap || ap->am_oid != typid)
elog(ERROR, "type OID %u not found in Typ list", typid);
*typlen = ap->am_typ.typlen;
--
2.26.2
--------------8FD28E9B65A94BB176003065
Content-Type: text/x-patch; charset=UTF-8;
name="0002-Allow-composite-types-in-bootstrap-20210116.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="0002-Allow-composite-types-in-bootstrap-20210116.patch"
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Truncate logs by max_log_size
@ 2026-02-04 09:48 Álvaro Herrera <[email protected]>
2026-02-05 02:17 ` Re: Truncate logs by max_log_size Fujii Masao <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Álvaro Herrera @ 2026-02-04 09:48 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; +Cc: Jim Jones <[email protected]>; Kirill Gavrilov <[email protected]>; Kirill Reshke <[email protected]>; Andrey M. Borodin <[email protected]>; Euler Taveira <[email protected]>; [email protected]
On 2025-Apr-01, Fujii Masao wrote:
> Since this patch is marked as ready-for-committer, I started reviewing it.
> Basically I like the proposed idea.
Hello, is this something that anybody is working on?
https://commitfest.postgresql.org/patch/5272/
Apparently it was very close to done but was abandoned after several
rounds of review at the start of the cycle.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Computing is too important to be left to men." (Karen Spärck Jones)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Truncate logs by max_log_size
2026-02-04 09:48 Re: Truncate logs by max_log_size Álvaro Herrera <[email protected]>
@ 2026-02-05 02:17 ` Fujii Masao <[email protected]>
2026-02-05 09:08 ` Re: Truncate logs by max_log_size Jim Jones <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Fujii Masao @ 2026-02-05 02:17 UTC (permalink / raw)
To: Álvaro Herrera <[email protected]>; +Cc: Fujii Masao <[email protected]>; Jim Jones <[email protected]>; Kirill Gavrilov <[email protected]>; Kirill Reshke <[email protected]>; Andrey M. Borodin <[email protected]>; Euler Taveira <[email protected]>; [email protected]
On Wed, Feb 4, 2026 at 6:48 PM Álvaro Herrera <[email protected]> wrote:
>
> On 2025-Apr-01, Fujii Masao wrote:
>
> > Since this patch is marked as ready-for-committer, I started reviewing it.
> > Basically I like the proposed idea.
>
> Hello, is this something that anybody is working on?
> https://commitfest.postgresql.org/patch/5272/
At least I'm not for now. So please feel free to work on the patch if
you'd like!
Regards,
--
Fujii Masao
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Truncate logs by max_log_size
2026-02-04 09:48 Re: Truncate logs by max_log_size Álvaro Herrera <[email protected]>
2026-02-05 02:17 ` Re: Truncate logs by max_log_size Fujii Masao <[email protected]>
@ 2026-02-05 09:08 ` Jim Jones <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Jim Jones @ 2026-02-05 09:08 UTC (permalink / raw)
To: Fujii Masao <[email protected]>; Álvaro Herrera <[email protected]>; +Cc: Fujii Masao <[email protected]>; Kirill Gavrilov <[email protected]>; Kirill Reshke <[email protected]>; Andrey M. Borodin <[email protected]>; Euler Taveira <[email protected]>; [email protected]
On 05/02/2026 03:17, Fujii Masao wrote:
> At least I'm not for now. So please feel free to work on the patch if
> you'd like!
If nobody is planning to work on this, I can take a look at it next week.
Best, Jim
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2026-02-05 09:08 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 02:48 [PATCH 1/3] bootstrap: convert Typ to a List* Justin Pryzby <[email protected]>
2026-02-04 09:48 Re: Truncate logs by max_log_size Álvaro Herrera <[email protected]>
2026-02-05 02:17 ` Re: Truncate logs by max_log_size Fujii Masao <[email protected]>
2026-02-05 09:08 ` Re: Truncate logs by max_log_size Jim Jones <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox