Feedback-ID: ie3de48e3:Fastmail
Date: Thu, 5 Feb 2026 11:22:19 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Fujii Masao <masao.fujii@gmail.com>, 
	Fujii Masao <masao.fujii@oss.nttdata.com>, Kirill Gavrilov <diphantxm@gmail.com>, 
	Kirill Reshke <reshkekirill@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, 
	Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Truncate logs by max_log_size
Message-ID: <202602051012.qer26xklakqb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <49861ed8-f1bc-4848-8762-703ccd344c56@uni-muenster.de>
Archived-At: <https://www.postgresql.org/message-id/202602051012.qer26xklakqb%40alvherre.pgsql>
Precedence: bulk

On 2026-Feb-05, Jim Jones wrote:

> On 05/02/2026 03:17, Fujii Masao wrote:
> > At least I'm not for now. So please feel free to work on the patch if
> > you'd like!
> 
> If nobody is planning to work on this, I can take a look at it next week.

That'd be swell.

My only comment at this point is that the proposed GUC name is not
great.  I think it should be something like log_statement_max_length, or
something like that.  Reading just the thread subject, people would
imagine this is about the size of the log file.

Another point is that the current patch does strlen() twice on each
query.  It might be better to do away with need_truncate_query_log() and
have a single routine that both determines whether the truncation is
needed and returns the truncated query if it is.  If it returns NULL
then caller assumes it's not needed.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/