Date: Thu, 5 Feb 2026 10:12:39 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Warn when creating or enabling a subscription with
 max_logical_replication_workers = 0
Message-Id: <20260205101239.3c432a7766bc962bad9c6c51@sraoss.co.jp>
In-Reply-To: <CAHut+Pt5KzE75ZyFZPC2fcb+GRes2DbHAh_vgfdDXoWmEV6hAg@mail.gmail.com>
References: <20260204140731.0e4b511906ac748abad1f3d9@sraoss.co.jp>
	<CAHut+Pt5KzE75ZyFZPC2fcb+GRes2DbHAh_vgfdDXoWmEV6hAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dGVsOC96TmpsZUVzNmYxcU5QTTRUcXAxRm5RRUsvMXBPSlMvL0NySnFBMVBX?=
 =?utf-8?B?aWFNMG9oeDFwOGJCOW9SZkpBcjRZZktiWUxRV0Z6Ny9jOUVSVjYvOFhZSlds?=
 =?utf-8?B?SU8zVHhzWC8xZENRYXZmT3pnYVlwMDBWNkdaS3lrLy92MVFPTjVUaGZQSWN2?=
 =?utf-8?B?aWR0VCs0NURiNUR5WFhaRU5rOWE1d1UxY3k1L1ZKWDQzamM2WUJyN3pJdWpr?=
 =?utf-8?B?Z0JIT2svcnMyOWZ2cE16UVFwa1J0c3N2RGYwamlRQW9xMGhkMTVObmNyek5l?=
 =?utf-8?B?MDFWZlUyUXhkMTFnSkFWa0UwY1Z4enlrR2MyWWV0VjFwZFBoR0FDazkwVlM0?=
 =?utf-8?B?YTJ2NkVLQVZsRHhEY3lKSmpPY3NKYUNVY0JxTEtpb3FiYkVFZkR0bDBFT3Bh?=
 =?utf-8?B?ZTV4ekZ2ZExrSStqVzhHUUVwMkhpeks3dkxzL0hjNE96MmVEaGdFbWJNdHh5?=
 =?utf-8?B?Q2pZSXJ6K2xuRFlxM3VOdElxUWZoL1lJNi9VcFZINW1qMUlQYThjZVNOY1cv?=
 =?utf-8?B?NUVkSC96V1FiY1grTlhNS3pOc0RCcFA5dkpQNzA5ZjlRbHA1NjdEaXV5eDA5?=
 =?utf-8?B?V215c0hTazlveVJnUDU2b0RhNDVHZGlxOXJqWEZMRnIwanMwNWh0RDFXeHZL?=
 =?utf-8?B?VWZUdGhhWEUzZUNoQ3pWM3VwWXRpanVyR0lBcWQwUUlPQ2QzaEtDQ2FhcGVO?=
 =?utf-8?B?aU5KZTArM2FkaEtaamNKSy95SXVDWk9MRm9lZTEyYkowYmdiQVRIV1FTU0ow?=
 =?utf-8?B?cmxCdUNhcFQ4UHQrU0RlVUJCSVRiUGVBSllHbXI5c2JOUFhMNVRENVJxVDZj?=
 =?utf-8?B?d2lOU25Kb29oOVQ4SjY0OTJVaGg2Y3Vmam5zQm4rSjg5MVRBb1dNY0JQRmM3?=
 =?utf-8?B?VWRZdEl5VDNDUHgvSHFpNkJyNUxNS2pvMmxoOVQzWEJRSXFuNXBUWi96cUxa?=
 =?utf-8?B?ZVFvbCs3MVNxMXQxMlNqSU80QVhQSDhPbDBBQWNWbXNaR2RnMXNkQmxWcEx4?=
 =?utf-8?B?dWltK1gyZndCOWFiYkJPeThZai84bnV1M2NxUFVHcDNDQTFXZGtOZWk1Zzhq?=
 =?utf-8?B?bmpFREhtU3BXV2p1TmN0RGo2eTdnZXdwL040aTJQQmRMNUhDa0pVdUp5SUFk?=
 =?utf-8?B?NWU0UE9Od3V3OVh5Zmo4bmdsVWs2aFRrMDM0SSszcU5PZThhY1VCUmdOQkY2?=
 =?utf-8?B?VmNJRnBTY2o5TjdwQkF3QXdyUldwZjVZUXVEM3M2ZkJJUlZ6RkliWmlLWFVJ?=
 =?utf-8?B?Z2RvZFdvWFZ4dWY4M01ORUt4TWcxZ0U5TzJnc2Z5TlF1TkVtUVpFend1a2c2?=
 =?utf-8?B?M3VQbERyVEFiWHlSeVIrT1FlZW9WZTByR1VyODlKYVJjN0Jkcm9RdjZITWs3?=
 =?utf-8?B?MEpMd1JKM3ZVb2JxdkMybFZ6Z0FFQXVYVHZPZWJCQm1IWGN3VFNHOXhTSWlZ?=
 =?utf-8?B?Nm1VOVQ0R3QzOGh6MysyMUdJaUFuRXE1NlhDZ3ZiZFpKcFZZSU55cU1DWDBV?=
 =?utf-8?B?alRJa212bTVlWHJ6OFZDdVhhRnZFQmRzKy8xb2E0eVltazVuZ05EWDk2RmFO?=
 =?utf-8?B?aytZY1F1czFjS0ZsQ2VFb2FJSWJpZ0hnUXFjS0k4aCtjL0RSUElVQVJWQTBI?=
 =?utf-8?B?bVpoS1B3c1hTOHBCUHA2SzgrR0NHcDkvcXBiRS94c1NtcnF5Wnl5UGZLUWlL?=
 =?utf-8?B?b2s4dWJkMUhLMUI3Ukh3ZCtlYmhEMHRSQXdCUFZhVlJmaUtCYnNMNHIwNVdx?=
 =?utf-8?B?Tm5aSnpGWWNYQUpLeU1naEVPSHVrK3NENVBWM1VqeHcrTm5qSkRkTDJXQTM2?=
 =?utf-8?B?NzAyTi9UdlduZ2EycUZaNkFRNWE3THdZSnFPb01DcHB4dHBIb1JJMGRGQlFG?=
 =?utf-8?B?UjBHNHFMdzhQQU9reFh2WXFpWkROVCtyTjlQd0VWbUcwUHdtRGdrOGw4aUxF?=
 =?utf-8?B?YWFNT0FEWXJ6VTFzUWFqa01NbWF2bG95NFl6Zmk2NzAreGl3MWlKUHJhNXR1?=
 =?utf-8?B?Q3VzVEFpOXRrS1lvZ1M4VzZvUWF5U2tMVGpSdFQxYWlXQnNYdU11WU0rWm1n?=
 =?utf-8?B?dVI0dDBvczZSZ2pjOXNtYzlLL3kyRStsbEFPT1M3Umg3bTNnOTdKZVNzWVpE?=
 =?utf-8?B?dFcwc1k0RXJ4S1hldTMyd0g1UE5ibUw4MWtVZVdYSXJNakVYazV6WUUrV3Zz?=
 =?utf-8?B?S2JraDJUVHdLUkorYk1vcVI1YkhuK09mTjI5bDRMZ1ArYzNaMFhEVWxPUXkv?=
 =?utf-8?B?OERHVzI0QW1kQzdOMkJTRGhEcWpwQlNEVGtLTGZiZTJDTEZyWVRpUG5TdzV6?=
 =?utf-8?B?b3BTMmxpN2RvMEZhcUZMVTBtVzk0citrMXNiU1hmSjRRQmhXeGFTNjV1aG9Q?=
 =?utf-8?Q?O4fcraVewNs5JdR8hrlP2yq0m6SzAiZn7nlDKQb75AWvn?=
X-MS-Exchange-AntiSpam-MessageData-1: Swu3SK5FkgvoVQ==
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 373a40e6-39d9-4c12-f1e3-08de6453a84c
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2026 01:12:40.2994
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /l8JPTQa+zQwWRrhy4+M2hmFkwDYQK4zjgAB3t0QOFGxhf3cf+DbK8xWnlsiynjPJSiyNbmgDjXMZkjE1CzIcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1P286MB3374
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20260205101239.3c432a7766bc962bad9c6c51%40sraoss.co.jp>
Precedence: bulk

On Wed, 4 Feb 2026 17:26:25 +1100
Peter Smith <smithpb2250@gmail.com> wrote:

> On Wed, Feb 4, 2026 at 4:07 PM Yugo Nagata <nagata@sraoss.co.jp> wrote:
> >
> > Hi,
> >
> > I would like to propose emitting a warning when creating or enabling a
> > subscription while max_logical_replication_workers is set to 0. In this
> > case, the CREATE/ALTER SUBSCRIPTION command completes successfully without
> > any warning, making it difficult to notice that logical replication cannot
> > start.
> >
> > Of course, users can confirm whether logical replication is working by
> > checking system views such as pg_stat_replication or pg_stat_subscription.
> > However, emitting warnings explicitly in these cases would make this
> > situation more visible. We have seen user reports where this behavior
> > caused confusion, with users wondering why replication did not start.
> >
> 
> Hi Nagata-San.
> 
> AFAIK the default for `max_logical_replication_workers` is 4. So how
> does the maximum get to be 0 unless the user had explicitly configured
> it that way?

That's correct, but the goal here is simply to make it easier for users to
be aware of this condition, since the current behavior provides no
indication that replication will not start.

> Also subscriptions require multiple workers in order to work properly
> [1] so why check only 0? Why not check 1 or 2 or 3.... those low
> numbers are also likely to cause similar problems aren't they?
>
> And what about when the  `max_logical_replication_workers` is 100, but
> those 100 are already being used. IOW, would it be more useful to warn
> when you do not have enough *available* workers for the Subscription
> to function properly, rather than checking what the maximum value is
> set to?

When max_logical_replication_workers is zero, the logical replication
launcher will never start. Otherwise, it does start and emits the
following warning to the server log when workers cannot be obtained:

WARNING: out of logical replication worker slots
HINT: You might need to increase "max_logical_replication_workers"

Given this, I think it is sufficient to warn only when
max_logical_replication_workers is zero.

That said, this warning is currently emitted only to the server log and
does not appear as a response to CREATE/ALTER SUBSCRIPTION. However, I'm
not sure whether emitting a similar warning as part of the
CREATE/ALTER SUBSCRIPTION response would add much value.

Regards,
Yugo Nagata

> 
> ======
> [1]  https://www.postgresql.org/docs/current/runtime-config-replication.html#GUC-MAX-LOGICAL-REPLICATION-WORKERS
> 
> Kind Regards,
> Peter Smith
> Fujitsu Australia
> 
> 


-- 
Yugo Nagata <nagata@sraoss.co.jp>