public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yugo Nagata <[email protected]>
To: Chao Li <[email protected]>
Cc: PostgreSQL mailing lists <[email protected]>
Subject: Re: pg_upgrade: fix memory leak in SLRU I/O code
Date: Thu, 5 Feb 2026 10:54:33 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Wed, 4 Feb 2026 17:20:49 +0800
Chao Li <[email protected]> wrote:

> Hi Hackers,
> 
> This comes from a previous review and has been on my to-do list for a while.
> 
> Since src/bin/pg_upgrade/slru_io.c includes postgres_fe.h, it is frontend code, so backend memory contexts are not used here.
> 
> In the current code:
> ```
> void
> FreeSlruWrite(SlruSegState *state)
> {
> 	Assert(state->writing);
> 
> 	SlruFlush(state);
> 
> 	if (state->fd != -1)
> 		close(state->fd);
> 	pg_free(state);
> }
> ```
> 
> the SlruSegState itself is freed, but state->dir and state->fn are not, which results in a memory leak during pg_upgrade runs. More generally, I don’t see a reason to free an object itself without also freeing the memory owned by its members.

As far as I know, AllocSlruSegState() and FreeSlruWrite() are not called
repeatedly in a loop, and the amount of memory involved is small, so the
impact of the leak seems limited. That said, I agree that it is better to
also free the memory owned by the struct members.

Regards,
Yugo Nagata

> 
> While looking at this, I also noticed that state->dir is allocated using pstrdup(). To better align with frontend conventions, the patch switches this to pg_strdup() and introduces a common cleanup helper to free all resources associated with SlruSegState.
> 
> See the attached patch.
> 
> Best regards,
> --
> Chao Li (Evan)
> HighGo Software Co., Ltd.
> https://www.highgo.com/
> 
> 
> 
> 


-- 
Yugo Nagata <[email protected]>

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pg_upgrade: fix memory leak in SLRU I/O code
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox