Date: Fri, 6 Feb 2026 12:54:14 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: "Matheus Alcantara" <matheusssilv97@gmail.com>
Cc: "Peter Eisentraut" <peter@eisentraut.org>,
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: Show expression of virtual columns in error messages
Message-Id: <20260206125414.8f8c5f5735aa34fb05c5cc72@sraoss.co.jp>
In-Reply-To: <DG796MZZAE5S.224STEF6SZTBZ@gmail.com>
References: <DG5DV8SED62G.2WFJB46D7WIT8@gmail.com>
	<7c18e854-0ddb-4670-b0c4-f2541b5edd91@eisentraut.org>
	<DG6DBW8NDTJC.1U9ELI7JCWOEB@gmail.com>
	<20260205114521.6fed028d8d3185663f3c4226@sraoss.co.jp>
	<DG796MZZAE5S.224STEF6SZTBZ@gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?y/YcWPPCGfiQjPFay8L4J8J/d2qrPwUzVB+XF/aLXIkiT/qih3kRQacZZfCc?=
 =?us-ascii?Q?Pta6sy1poG8RPYqCTsoaFCfq2uHtYRBZYGX3GJXsLYyvzXQh+0TR/gjsfjNX?=
 =?us-ascii?Q?syYMqOyf217IGtx0ols9gHO8NjM5cO4doMIpt8Wa6hfEN2jJyXHQH3AvY3TY?=
 =?us-ascii?Q?I/ro0SHMfrWY4THgANWKl/IjBk4UF9+qs5aCOPXEN2du8nseDb5gDPTXvgG2?=
 =?us-ascii?Q?9GaCoH6aqHyphYvDYHuhbKHIeqesXH7CmZVHP1sjidPs5v9uq2qxXnjxWKzp?=
 =?us-ascii?Q?6tMVVzveLF2F5mUIMxv2G7BSPmNb75PA9MdIYaJKJ1GEAhBXKdGkEkwurzqo?=
 =?us-ascii?Q?iehUoyVVvY1gy/75ojMtEFEDiZw4uxykY4hXhVrpHRdFJAcDjGo38yjJyGhN?=
 =?us-ascii?Q?wPnLuh1MShJs1DJ55XrWUIIuCn1JJgW3FjjQj2wls9UZjHvL7KZfUh1esOP6?=
 =?us-ascii?Q?QW8OUgOuNUNnIRIDQop5jvVIjYBcIHf2Rwr0ZSemMq2W2yQmD30IQOPJkA6F?=
 =?us-ascii?Q?rYINrkLoZaDcBYPOZPi9ZWjBAGe+mwFbxuVbde8gq7l+VS9AMmmxFyazFpjZ?=
 =?us-ascii?Q?/AGgoRceyJt/K6SWxJvgc87KBmbWGdu3JhISMUK+04llK+qmGsDDFk8zwzWX?=
 =?us-ascii?Q?qeDnaO/X4LxE3Y1hJx34JHbmVldU7ORgZcOrCX4PSJJSC0/miXN71DaN1T3p?=
 =?us-ascii?Q?+3TczAyKSC5fJMV3aNS9j4TLjw1XNQKXlMv9B4V+bhhk5L6kSOhpb4vluUF6?=
 =?us-ascii?Q?1oGH/L2im7FFoSZhXT1ZqsLnqY/WwTUC7luONytviGKswrywXEBTgikFbYJU?=
 =?us-ascii?Q?kfQbF4/3wBN8GWg1qYWDqNphYPzZaDA6XRXE2D+pQ2MJbCOWsWohI3M+SQL0?=
 =?us-ascii?Q?O1tSk1DEtSAG0AGZXuSlTjCvQy7X/zd2A4kraDLtx5NGwc0YwF2RP+YJ0Fha?=
 =?us-ascii?Q?7oj0aBbdFdbOlwKEd9ZXTyTSsMueVYQawy2zLpn9Dwuyrv5qezgMS54dcvxO?=
 =?us-ascii?Q?jA9zyx65483CH5ipQg8586YnzttNKIwCdfcBfl8Ky199JrT6JSx12al57EwO?=
 =?us-ascii?Q?Pl8t1J3VJrfJVxJ1OqlFDVNVBxYKsAXUsmXnsv41/EqAQmntwIwNxzmmmnCV?=
 =?us-ascii?Q?M8sqMY5x6unozxwpx4MreIYw29zxt6dAlfjCDUhJIsQfKn6zAomWH5FqLMXU?=
 =?us-ascii?Q?VklX1XH5AhuVszpKDOxCeegAAei94ygWcg1XwuGtDFIHZ7ctbzcH+gticKVs?=
 =?us-ascii?Q?BMikozs//8w0pOLLPmrMeRRstpIYvrOog95JgRZWehsg5xYHgHqSXGUDSiIg?=
 =?us-ascii?Q?N3EBYPLh61CtoOkwxDf5qYXTqYTjqgXhdCSqGNh6RB9HgF82+a1dRc6/yGya?=
 =?us-ascii?Q?tMeyhzFCxLHeZIOvcRkyh9rSzbuCLHHfZZpi42+dUr/7RgkVqxFk0t6esvpE?=
 =?us-ascii?Q?hKX2IJQhXz2jpYafd2aGZsFs7AziHsWBMDKLM+4y2NUQ26MRP0JqUW5ikPOG?=
 =?us-ascii?Q?dySK8xNSRuUcrJfQlzgZUMe3FlJuu7bAWR2EyWVqptgZiC5RyiMG9H0u4Dmm?=
 =?us-ascii?Q?5qGJAGcWtHcNQqtABGWRAwUtnMQzK54CovxR+TmLDLoyDsp0ZirpPTzLHuHv?=
 =?us-ascii?Q?4AG9hyKlbFLy8KDIYPJsVwfKlx4uFKSDsZ4ZAyjQUqS44brcUIz6rDrazM1L?=
 =?us-ascii?Q?3gsWalwA+dYtH1Z347rHCa64KtLRHsN+x0vhSZxVCu36nkGQL29DuUlpo5Bp?=
 =?us-ascii?Q?Ul7wzFb+9Q=3D=3D?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 99415822-6fe3-431b-a347-08de653364f4
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2026 03:54:14.5848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KHRnin3kdbAkaRK1TjYZJEQ0o/Nj2KuE2ysrHcjumKGtLyt2EC4hj7Jfbf1+DeYlj7nAHLv6NiPh/VLM1DBH0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB6599
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20260206125414.8f8c5f5735aa34fb05c5cc72%40sraoss.co.jp>
Precedence: bulk

On Thu, 05 Feb 2026 15:51:54 -0300
"Matheus Alcantara" <matheusssilv97@gmail.com> wrote:

> On Wed Feb 4, 2026 at 11:45 PM -03, Yugo Nagata wrote:
> >> Another possibility would be to get the actual values of "a" for example
> >> and show it on the error message, e.g:
> >> 
> >>     ERROR:  new row for relation "t" violates check constraint "t_c_check"
> >>     DETAIL:  Failing row contains (5, 10, 5 * 2).
> >
> > That would indeed be more useful. One way to achieve this might be to
> > modify deparse_context and get_variable() so that a Var is displayed as its
> > actual value.
> >
> I'm not sure if I understand how modifying deparse_context_for() could
> help on this.
> 
> What I did was to use the expression_tree_mutator API to mutate the
> virtual column expression to replace any Var reference with the value
> into the TupleTableSlot. Please see the attached v2 version.

I initially thought about having deparse_context_for() directly output
actual values for Var references, but that does not seem like a good
approach. Replacing Vars with Consts beforehand using
expression_tree_mutator, as you did, looks like a better solution.

One thing I noticed is that some expressions in virtual columns (e.g.,
NULL and negative integers) differ from those in normal columns, for
example in the following (null vs. NULL):

+DETAIL:  Failing row contains (null, NULLIF(NULL::integer, 0)).

However, this seems acceptable.

Overall, this patch looks good to me.

Regards,
Yugo Nagata

> > Another possibility would be to include column names in the DETAIL message,
> > for example:
> >
> >  ERROR:  new row for relation "t" violates check constraint "t_c_check"
> >  DETAIL:  Failing row contains (a, b, c)=(5, 10, a * 2).
> >
> > Although this would change the existing message format, including column
> > names could generally provide users with more information about the error.
> >
> I think that this could make the error output too verbose when there is
> a lot of columns involved on the statement.
> 
> --
> Matheus Alcantara
> EDB: https://www.enterprisedb.com
> 


-- 
Yugo Nagata <nagata@sraoss.co.jp>