public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Tue, 17 Feb 2026 08:20:20 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAAe_zA7FjgFGgVHXKUP2pXzctdioELseTKA8wgMJOS1gv_+8g@mail.gmail.com>
References: <CAAAe_zB+W+xBJpYNzRLzh6BH9HrFycTjoPUnVvnU1BT_7RR8Bw@mail.gmail.com>
	<[email protected]>
	<CAAAe_zA7FjgFGgVHXKUP2pXzctdioELseTKA8wgMJOS1gv_+8g@mail.gmail.com>

Hi Henson,

> Hi Tatsuo,
> 
> Thanks for rebasing to v43!
> 
> I noticed the Cirrus CI 32-bit build (test_world_32) failed on three
> tests, all due to the same root cause in rpr_explain.out:
> 
>   Sort Method: quicksort  Memory: 27kB  (expected, 64-bit)
>   Sort Method: quicksort  Memory: 22kB  (actual, 32-bit)

I noticed that too.

> The rpr_explain_filter() function was already normalizing the RPR
> Storage memory values, but missed the Sort node's "Memory: NNkB"
> which also varies between 32-bit and 64-bit due to pointer/struct
> size differences.
> 
> The attached incremental patch adds Sort Method memory normalization
> to rpr_explain_filter(), using the same approach as the existing
> Storage and Maximum Storage filters.

Looks good fix to me. Is that Ok for you to not release v44 patch
immediately?  Our patch set is very large and I hesitate to post a new
patch set too offten.

>> The node serialization functions (141 lines, 0% coverage) are the
>> > largest untested area.  I'm not sure how to trigger these paths
>> > in the regression test framework.  Any suggestions?
>>
>> I think we can leave it as it is, until reluctant quantifier is
>> implemented.
>>
> 
> Agreed.

Thanks for agreeing on this.

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox