public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tatsuo Ishii <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Row pattern recognition
Date: Tue, 24 Feb 2026 14:09:27 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAAe_zAc4CQDMP5WVuNZq5q6A_CymN5xwrva38df3okrtYdYsw@mail.gmail.com>
References: <CAAAe_zAxEqdyoOgx4u0A2RXu829CE-RJbJjg1jVz00j3aSYryQ@mail.gmail.com>
	<[email protected]>
	<CAAAe_zAc4CQDMP5WVuNZq5q6A_CymN5xwrva38df3okrtYdYsw@mail.gmail.com>

Hi Henson,

>> BTW, in create_windowagg_plan (createplan.c),
>> around:
>> /* Build RPR pattern and filter defineClause */
>>
>> collectPatternVariables, filterDefineClause and buildRPRPattern are
>> called in a block without any if or any other conditional
>> statements. This is an unusual codiing style in PostgreSQL.  I suggest
>> to fix this.  Attached is a proposed patch for this.
> 
> Good catch, thank you!  I've renumbered your patch as nocfbot-0007
> and extended the same cleanup to rpr.c and parse_rpr.c as
> nocfbot-0008.
> 
> nocfbot-0007: Refactor create_windowagg_plan to remove bare
>               variable-scoping block (your patch, renumbered)
> 
> nocfbot-0008: Remove bare variable-scoping blocks in RPR code
> 
>   Applies the same cleanup to rpr.c and parse_rpr.c, with minor
>   pgindent formatting fixes.
> 
> I'll keep this coding style point in mind for future code as well.

Thank you for quick response!

Best regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Row pattern recognition
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox