Feedback-ID: ie3de48e3:Fastmail
Date: Tue, 24 Feb 2026 18:08:04 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Bryan Green <dbryan.green@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>,
	Jakub Wartak <jakub.wartak@enterprisedb.com>,
 Michael Paquier <michael@paquier.xyz>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)
Message-ID: <202602241705.pd2wr4oku4nh@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0f76b00a-8d8d-4c6f-ba41-bf6ec5fb08e1@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202602241705.pd2wr4oku4nh%40alvherre.pgsql>
Precedence: bulk

On 2026-Feb-23, Bryan Green wrote:

> I have removed all but the SymCleanup form the backtrace_cleanup since
> it happens at process exit.  I have implemented not retrying as you
> described above.
> 
> Let me know if this was what you were thinking.

OK, thanks, that's pretty much what I was thinking.  I've pushed this
now.  One last change I did is add a check that the wchar2char() return
value isn't the full size of the output buffer, because IIUC that's the
way it's intended to be used, and it matches the one existing caller
that doesn't rely on the max_encoding_chars thing.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Entristecido, Wutra                     (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"