Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2aO6-000Q8i-2S for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 19:47:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w2aO4-004UrF-2O for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2026 19:47:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w2aO3-004Ur7-2u for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2026 19:47:32 +0000 Received: from fhigh-a1-smtp.messagingengine.com ([103.168.172.152]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w2aO0-00000000ezn-0R9t for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2026 19:47:31 +0000 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5AAF914000AE; Tue, 17 Mar 2026 15:47:26 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Tue, 17 Mar 2026 15:47:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm3; t=1773776846; x= 1773863246; bh=refrRGcl2/8MYDn1oNMTuc3A2Got/gblMfvJmfJM12Y=; b=f vGdprYHc98pH2ZOrNbmTjrZtUju6E8NB9sclCIsBX9zuqltrsPjfK5EBiaZBC4a9 QUcbhmeN5ssqukAL+LuI2gbKGRSIA/VHyFrChEuBI9VgvBGrDQ7C2BsIfgh55lHJ ZvmMpyD2gSbAsU9uS9ZDeuvZfEu5Y4B43fTw9On+E0OiyqqDLAQWcLyvrfEKh5qm weMp/uhKSxMere6Fvx+PL8Qa5iPRrmsKZpUTIExhvT5b+Lk2B6bSYLWqD3KMUDMA j2Wf58UcuGN34AYNEoH33Jv0IIclNTKw+oSJnVjeL8u4LbYJOLB2TjzZROSEkhRU tuZ50CZEhFdI6cJGNgi3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1773776846; x=1773863246; bh=r efrRGcl2/8MYDn1oNMTuc3A2Got/gblMfvJmfJM12Y=; b=TmUSwA3Pam1HW9Pxi /2pYlqKv/awaxTH6jkB4wsM/rqlS8GIl2SdLz1iaoOJUUeFfLCyO9cwUYIJW5AaN HvvLWmZnXi1pPUcU5JqnAqPN2ZCW7T99e21O6bn2fB4ot+z+q8yKjREhctxoTbLQ itx4R+i0eU32EoiZkOY6N2lxLRvrkP+eVPklJ/ZgNoSskdPQHManlFz6X7DXfuzP b/xdA8cYJtwO9/ma85CGY0Y15h8ZhYhRX1LHWSJIKiIth1ezkkoHUmmRTvIqg3hS RIVNN3Yvx3jhuyG1L/D3d/PZtyaFfmqPGzKBkZIGFrGz3s42zefOL7/TsmTKo8Ru MCFvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftddvudegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheplmhlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsehkuhhrihhlvghmuhdruggvqeenucggtf frrghtthgvrhhnpeetuedvheffkeevgfeuheevteevkefggedttdeufeeuheduuddthfef fffhjeefffenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgv sehkuhhrihhlvghmuhdruggvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehnrghthhgrnhgusghoshhsrghrthesghhmrghilhdrtghomhdp rhgtphhtthhopehpghhsqhhlqdhhrggtkhgvrhhssehlihhsthhsrdhpohhsthhgrhgvsh hqlhdrohhrgh X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Mar 2026 15:47:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1773776842; bh=k+KJOsyMxqBGebT3O/SFxWnxUitI0wCWqAjafLjmw6s=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=leTM62X0KzP929Y2gA/FomIJN0DJcAyZhRQhlNaDa59ojnRPQCBmz1E59DB1iUVSL SaLsGMEz3hhLfzTEuEfONj79d/JrwXS6yIZcmf9nCvl1grH63PhH/qTbVKiHTeRcK/ AYuUl15gALY+dKfdwXtWfW6zNcLg4VhNF1Ys/L1iejZqGBShEpwfGDQ/aPN3WcN7oy JsM10d7ELDpHTORJ8fYVKDOm6XkJ5EQR//Pn9cLUkf1/HbnHoj6eiU3419A0oDFo83 /bEgdobX81vC2OI8cRG0mJGy61lhgFOyckYi0DK771YpzLPtfJPEGV3PX6VRrvmsyI 7BHu47HLKpO5A== Received: by schmee.kurilemu.internal (Postfix, from userid 1000) id 798C37B; Tue, 17 Mar 2026 20:47:22 +0100 (CET) Date: Tue, 17 Mar 2026 20:47:22 +0100 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: Nathan Bossart Cc: Pg Hackers Subject: Re: table AM option passing Message-ID: <202603171944.2qugoabbkfqr@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Nathan, thanks for looking, On 2026-Mar-17, Nathan Bossart wrote: > On Tue, Mar 17, 2026 at 05:50:41PM +0100, Álvaro Herrera wrote: > > (This change is vaguely similar to b7271aa1d71a, except I used 'int' > > instead of 'bits32', to keep the interface consistent with the existing > > heap_insert() one. Maybe I should make all three take bits64 instead? > > We don't actually have that type at present, so I'd have to add that > > too.) > > Why bits64 and not bits32? I must be missing something. augh, that's just a thinko -- yeah, we could use bits32 here and that wouldn't represent a reduction in number of possible flags. Does anybody oppose changing table_tuple_insert() to use bits32 instead of integer for the 'options' argument? -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "I dream about dreams about dreams", sang the nightingale under the pale moon (Sandman)