Feedback-ID: ie3de48e3:Fastmail
Date: Tue, 24 Mar 2026 17:16:11 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>, Jeff Davis <pgsql@j-davis.com>,
	Greg Sabino Mullane <htamfids@gmail.com>,
 "L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Subject: Re: Adding locks statistics
Message-ID: <202603241611.3vnou5cwxdpq@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <acD3PUbZ0ZER+hCl@ip-10-97-1-34.eu-west-3.compute.internal>
Archived-At: 
 <https://www.postgresql.org/message-id/202603241611.3vnou5cwxdpq%40alvherre.pgsql>
Precedence: bulk

Hello,

On 2026-Mar-23, Bertrand Drouvot wrote:

> So the changes done in your patches make sense to me.
> 
> I have 2 comments:
> 
> 1/ wait_event.c
> 
> -#include "storage/lmgr.h"              /* for GetLockNameFromTagType */
> -#include "storage/lwlock.h"            /* for GetLWLockIdentifier */
> +#include "storage/lmgr.h"
> +#include "storage/lwlock.h"
> +#include "storage/shmem.h"
>  #include "storage/spin.h"
> +#include "utils/hsearch.h"
> 
> hsearch.h is already included into shmem.h so its direct include is not needed.
> That said wait_event.c needs it so including it directly might make sense just from
> a coding "style" point of view (given that it is  harmless as it is protected by
> ifndef HSEARCH_H).

Hmm, right -- I don't need to add both.  Done that way.  I also made
some alphabetical sorts and pushed this part.

> 2/ Not directly linked to your patches
> 
> It looks like that aio_funcs.c does not need lock.h (reported by include-what-you-use).
> If we remove its direct include, it's still indirectly included through proc.h
> though. But I think that removing its direct include makes sense as it's not
> needed at all.

I'm not opposed to somebody else making this change, if they want, but I
think there's little practical impact.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"En las profundidades de nuestro inconsciente hay una obsesiva necesidad
de un universo lógico y coherente. Pero el universo real se halla siempre
un paso más allá de la lógica" (Irulan)