Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 1 Apr 2026 16:27:18 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Andres Freund <andres@anarazel.de>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Zsolt Parragi <zsolt.parragi@percona.com>,
	Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: table AM option passing
Message-ID: <202604011417.bwthhrwmivd4@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3myajthupiacptbt"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <40E570EE-5A60-49D8-B8F7-2F8F2B7C8DFA@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202604011417.bwthhrwmivd4%40alvherre.pgsql>
Precedence: bulk


--3myajthupiacptbt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2026-Apr-01, Chao Li wrote:

> 1 - 0001
> For table_tuple_delete(), options is added and changingPart is
> removed, but the header comment should be updated to reflect the
> change.

True, fixed.

> 2 - 0002
> For table_tuple_update(), options is added, the header comment should
> be updated as well.

Done.

> 3 - 0002
> Now TABLE_INSERT_SKIP_FSM, TABLE_INSERT_FROZEN, TABLE_INSERT_NO_LOGICAL belong to the same options word as HEAP_INSERT_SPECULATIVE, but they are still defined as:
> ```
> #define TABLE_INSERT_SKIP_FSM 0x0002
> #define TABLE_INSERT_FROZEN 0x0004
> #define TABLE_INSERT_NO_LOGICAL 0x0008
> ```
> 
> Could it make sense to change them to the left-shift form?

Yeah, I don't know.  I don't like this style, but some people like it,
and I don't want to get into an argument about this kind of thing.

> 4 - 0002 
> In heap_multi_insert(), heap_prepare_insert(), and heap_insert(),
> options is defined as uint32, but in RelationGetBufferForTuple() and
> raw_heap_insert() it is still defined as int. Would it make sense to
> take this opportunity to change all “options" to uint32 for
> consistency? Otherwise, if this is left for later, a trivial follow-up
> patch just to change int to uint32 may be harder to get processed.

Hmm, this is actually a problem in 1bd6f22f43ac.  I added a preliminary
patch that should fix this.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"No renuncies a nada. No te aferres a nada."

--3myajthupiacptbt
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v5-0001-Fix-callers-of-heap_insert-and-siblings-to-use-ui.patch"