Feedback-ID: ia2694551:Fastmail
Date: Thu, 2 Apr 2026 10:27:21 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>,
	Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <202604020825.agnq44uixbwk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAFC+b6qB=R7_jwZ5aSFJ=9CaTDbYhkK2hs1f0VS0gxiQC-Pvxw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202604020825.agnq44uixbwk%40alvherre.pgsql>
Precedence: bulk

On 2026-Apr-02, Srinath Reddy Sadipiralla wrote:

> On Sat, Mar 28, 2026 at 12:12 AM Srinath Reddy Sadipiralla <
> srinath2133@gmail.com> wrote:
> 
> > Hi Alvaro,
> >
> >> I don't disagree with changing this, but AFAICS the patch as presented
> >> provokes multiple test failures.
> >
> > Fixed with the attached patch.
> 
> Just want to remind about this patch.

Yeah, it doesn't apply anymore.  I rebased it some time ago, but it
still failed a few tests -- I'm guessing you don't have either TAP tests
or injection points enabled, which would explain why you don't see those
failures.  So please rebase it against v49, but also look into making it
pass all tests (I suggest making it go through CI).

Thanks,

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"We’ve narrowed the problem down to the customer’s pants being in a situation
 of vigorous combustion" (Robert Haas, Postgres expert extraordinaire)