Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 3 Apr 2026 00:14:51 +0200
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: some more include removal from headers
Message-ID: <202604022213.ijh54ljfsfb7@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="rmdldozsotr5364u"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <hwxrclx2dlhr33y4ewnrwnhkpli34fof5vlfmhfe3ycxettg4c@wlrc6zyfwkak>
Archived-At: 
 <https://www.postgresql.org/message-id/202604022213.ijh54ljfsfb7%40alvherre.pgsql>
Precedence: bulk


--rmdldozsotr5364u
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hello,

On 2026-Apr-02, Andres Freund wrote:

> On 2026-04-02 20:24:29 +0200, Álvaro Herrera wrote:

> > Looking at what else includes bufmgr.h, I think the minimum it can
> > reduced to is compiling 157 files when you change bufmgr.h, per the
> > patches attached here.  Most of them are direct inclusions, so reducing
> > further is tough.  The only one we could blame is xlogutils.h, but it
> > needs the ReadBufferMode enum, so in order to do better, we'd have to
> > split bufmgr.h in two.
> 
> I think you may have forgotten to attach the changes?

Hm, so I did.  Here they are.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Las mujeres son como hondas:  mientras más resistencia tienen,
 más lejos puedes llegar con ellas"  (Jonas Nightingale, Leap of Faith)

--rmdldozsotr5364u
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="0001-don-t-include-bufmgr.h-in-nbtree.h.patch"