Date: Fri, 3 Apr 2026 10:10:32 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Subject: Re: Allow to collect statistics on virtual generated columns
Message-Id: <20260403101032.49bc223b0974c9dd3b1de9a4@sraoss.co.jp>
In-Reply-To: 
 <CAEZATCVtSyr1eOmHT=8B4i=RqHHM6_vbhLJhJorU+F89MMpA-A@mail.gmail.com>
References: <20250422181006.dd6f9d1d81299f5b2ad55e1a@sraoss.co.jp>
	<20250902163341.c174d0e83eedfc54d68b8e9c@sraoss.co.jp>
	<20251231194455.5975fda68ed8e941e4afb805@sraoss.co.jp>
	<CAEZATCV6=q0-5HFBMg4jFS-j1ZCwANhp1sLXBQZYsK2ZLwq0AQ@mail.gmail.com>
	<20260324195727.43416b69c71b5f63eed3b4bc@sraoss.co.jp>
	<CAEZATCUR5B=6M7H2bwRU0_6FrbSE8yHe_+9bTbRUdU=jE33yog@mail.gmail.com>
	<20260325130127.7bc85919861f494ce7c332a5@sraoss.co.jp>
	<20260327000931.d2303c198c7c9445e90aeab7@sraoss.co.jp>
	<CAEZATCWkQhG0fwz5Z34vn=LcKdCb3DGfomPPwcXL_qtKfEt5+w@mail.gmail.com>
	<20260327021807.3ae563de0a288086b98755fb@sraoss.co.jp>
	<CAEZATCV5ZbGZzmqKPow9tsaVuE3vmTU4WwEq0wHrsM=QHBpUEQ@mail.gmail.com>
	<20260327143511.d84a76decfcbd6b80bdf56ed@sraoss.co.jp>
	<20260327164359.ee19c1e71c80163517a1051e@sraoss.co.jp>
	<CAEZATCXMxaMP68A9HjC0NtMtzCfVyvDiYjH-zOVLcLj5B1pFgg@mail.gmail.com>
	<20260331233517.05fbaa30b1b0b96d16b0d556@sraoss.co.jp>
	<CAEZATCVtSyr1eOmHT=8B4i=RqHHM6_vbhLJhJorU+F89MMpA-A@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?7BIzjoXa9qy+g/evH6XlAweC1G8k7Upp6WKAmntTPMQyW0B65g0CaTAGfK3S?=
 =?us-ascii?Q?EPe88IJa7NI538zWyDMIq7nODK/0zeeBEbtVdUEG7EUlsDjKvNDLZT2uD+fS?=
 =?us-ascii?Q?Ywvpn44NYcZw+GfrFVM8cFo9ByU/K4fagdNbw68qmlc6RsrAXnJbhsmhcO06?=
 =?us-ascii?Q?SO+yLqA8Fn+SvojPuE6B7YIPeoo9/gnWdZrB4HdSvw8n6gviZRQdLIyytlcA?=
 =?us-ascii?Q?vnIK7DUwF0z4BxMmdmMSS8XlbfFe05bQifbtoan9DTKgv2HPr/D0SGC6R94f?=
 =?us-ascii?Q?9REccx+gW9A+vtpXHcOa1WjyfLVVDHrxlVjKt9z4BZnk6WTyL8RXpelMzqxe?=
 =?us-ascii?Q?ecRD+CRtQuRrxnQ+Hoe7QmRVT3OvjitMNJQhuH25mwfRNDlM2hlvWKWhNKVC?=
 =?us-ascii?Q?Gp6lOn5c1/QBoU5bNpOXLOLh5bllM9wig6fSonJuT539fLR97KtZ3FUera4/?=
 =?us-ascii?Q?dFdGQjIJwbNvR4n92F/giotgvGLrg88V5H4TJk81P5nPeUESFF02Ez0aFwKE?=
 =?us-ascii?Q?ytxQWzj/4r8mxvCzOgPbBHwTkOkWM8E1vqU7akJj4TwJ3dxEdVaWqM+h/tXy?=
 =?us-ascii?Q?c2nt+uBAiNCxBeWd67dkjYXpbPCyiV36jW26dZmmgxaow6y76zU1emLLRAXf?=
 =?us-ascii?Q?3QAUS+b8jsvwhsYiZuLNgNOQi6our8MOz/xTIVhyQRZgORMD0679sHwglISz?=
 =?us-ascii?Q?DRYyKORD1fd/BEnFgn8Cmc3jJ7cO+FnaI8kDVNp7UoPj+bhcb26lDP++IRHu?=
 =?us-ascii?Q?FjT4WVYGD/DqLhNl7Ag3kJfF7DmQY37UlwiJmqtsPDPi3cfVkE8EJjrKEbJi?=
 =?us-ascii?Q?lt3urmmK65E+T0FfifBkLJVBlVefgK7/E71Q+DN19rm4Y2x9N/ZzJ9gsShoC?=
 =?us-ascii?Q?/pMObl/lYhW3wAHLA8e9ypXGoU3Sw8bmosEXhefZ/hdwWyPVQWJRLw/fJZOX?=
 =?us-ascii?Q?KGzhdV8Lv97SwhXkb/JWLbaQGkbPbUiLQ31P0mxj4RJkrA++p1wltGzwryjh?=
 =?us-ascii?Q?vdTrDWzJQ2ZbU+6G3J4WCy6lH8UvtZmR08eh397jfkVLjRBitowlhkbKfI1W?=
 =?us-ascii?Q?JNVSQZUaVRiFHFCjqMxRqrA5sw7tXIjXAJLSKHickVWb3iHd38CqktH/99GZ?=
 =?us-ascii?Q?6/Tjyd1/+sVffM5zBfUxnP0iu0jpP0PDEu/JqpdgIOqJGZx/8PSo+tX4s1bp?=
 =?us-ascii?Q?5SaH+aN0rzsmzgJgAsVrDruhWjAX2n2cD3Nop0dfx36DhFz9QQ9PSq99Uydz?=
 =?us-ascii?Q?eioUJ7FKSqEE6Je89oJExGSzX7kRI3td40xTlYYYgwjX0B2I8aOw7p1bqd7L?=
 =?us-ascii?Q?OJ5Pil7UYcIc//9zGWi8kVZ+LVVnT6N9OS1NgXUXa+2zM2QuiMAVyP1wnoML?=
 =?us-ascii?Q?EmTr318gGFEdT1ExO3G+RIHBJutc3K6fcdzRfxoo3OUc/jQgMQB4rrxfwll+?=
 =?us-ascii?Q?sVBG9nRNze95NTmqVAAYaZQHoUgUzGVF3kzLwv++25o3A7ALEDXfc7Yw+HUW?=
 =?us-ascii?Q?S7Rdvbeswz7c61UDQFxTljRgv4XiO/gVtte5rqybWnb9vpFfCaP0Y1n/IEGW?=
 =?us-ascii?Q?NpMsJfao4o7H/x97M1SLmQV0qwBFeyZqw/n0zKbfWqZlQCH8xWoOvzBnMoyf?=
 =?us-ascii?Q?V+O4AQiup1ctGO9JJ7FGMvXcfjv4POiFu5MfalKxvkLDSNUpJH4KF8x/L8nT?=
 =?us-ascii?Q?juPU8Z+yLAE7kt3irEEOw+gSlrONWH40xd2D8mE99jjdbXNNKLu18YVaJnVQ?=
 =?us-ascii?Q?RRFC2PhgLwfe+J4z5iVqAApvkP3XAhEyhMybGK09NL3UMp9GKXKXNEGctHvx?=
X-MS-Exchange-AntiSpam-MessageData-1: K4SfXxKwD1+yWg==
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 5024843c-de87-4fbd-b8cd-08de911dcdf2
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2026 01:10:32.9751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 vWw91kLPzEGoyIqJM7x5SqFGRgy/NfIQT6tkAlHZvgKVEH4mClCiWeIvyATvxDHRbSPmselOdioo+PNe2+Un1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1947
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260403101032.49bc223b0974c9dd3b1de9a4%40sraoss.co.jp>
Precedence: bulk

On Wed, 1 Apr 2026 17:12:38 +0100
Dean Rasheed <dean.a.rasheed@gmail.com> wrote:

> On Tue, 31 Mar 2026 at 15:35, Yugo Nagata <nagata@sraoss.co.jp> wrote:
> >
> > Thank you for updating the patch. I am fine with that.
> >
> > One concern is that users might interpret "stored" as referring to
> > "stored generated columns", rather than including regular columns,
> 
> Yeah, possibly. I changed "stored" to "non-virtual", which should
> reduce the chances of that particular confusion.
> 
> > Also, the meaning of "automatically" might be a bit unclear, so we
> > could clarify it by adding "without defining extended statistics."
> >
> >       Defining extended statistics on a single <emphasis>stored</emphasis>
> >       column is not supported or necessary, because statistics are built
> >       automatically on such columns without defining extended statistics.
> 
> OK, pushed that way.

Thank you!

> 
> I also noticed that a few places in CreateStatistics() could use the
> variable "numcols" instead of "list_length(stmt->exprs)", so I changed
> that.
> 
> I decided to include the change to the error message discussed in [1],
> since there seemed to be a consensus there, except that I think it
> also needs to make it clear that it refers only to non-virtual
> columns.
> 
> In addition, there was another nearby error message which was no
> longer quite right for statistics on virtual generated columns, and I
> changed the order of checks, since that allowed the "if" statements to
> be simplified a bit.

I reviewed the commit, and it looks good to me.
Thanks again.

Regards,
Yugo Nagata


-- 
Yugo Nagata <nagata@sraoss.co.jp>