Feedback-ID: ia2694551:Fastmail
Date: Sun, 5 Apr 2026 22:41:50 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Antonin Houska <ah@cybertec.at>
Cc: Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <202604052035.il2hp2wze6pz@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="k3knmf76cw7vbhar"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202604051852.qfdnfvemfkd2@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202604052035.il2hp2wze6pz%40alvherre.pgsql>
Precedence: bulk


--k3knmf76cw7vbhar
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi,

So here's a v55 version of the base REPACK patches that I'm feeling
comfortable calling very close to committable.  I'm going to give an
additional read tomorrow and maybe make cosmetic adjustments, but there
should be nothing substantial.  Of course, the subsequent additions in
the other patches of v54 are still in the cards, and they are most
likely essential.

Changes compared to v54:
- changed reform_tuple() to not deform the tuple if no attributes are
  going to be touched.  We can simply make a copy instead, which I
  suspect is considerably cheaper (but I didn't measure).

- cleaned up worker shmem shutdown callback.  I think it's how it is
  because it copied parallel worker code, but that has a weird structure
  for --as far as I can see-- no good reason (we oughta change it too)

- renamed the worker from pgoutput_repack to pgrepack.
  (Note that this is an internal name that users don't face.)

- reverted some unnecessary changes to master

Thanks

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

--k3knmf76cw7vbhar
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v55-0001-Rename-cluster.c-h-repack.c-h.patch"