Feedback-ID: ia2694551:Fastmail
Date: Tue, 7 Apr 2026 12:30:07 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>,
	Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
 Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Noah Misch <noah@leadboat.com>, vignesh C <vignesh21@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Message-ID: <202604071027.sixw2cst46e2@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CANWCAZaOs_+WPH13ow33Q==+FwBwVZkqzm4vND=WEB4_NBmv1Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202604071027.sixw2cst46e2%40alvherre.pgsql>
Precedence: bulk

Hi,

On 2026-Apr-07, John Naylor wrote:

> mamba is failing with
> 
> repack.c: In function 'initialize_change_context':
> repack.c:2946:7: error: cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
>  2946 |       (Datum) NULL);
>       |       ^
> cc1: all warnings being treated as errors

Hmm, yeah that should have been "(Datum) 0".  Pushed.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"The Postgresql hackers have what I call a "NASA space shot" mentality.
 Quite refreshing in a world of "weekend drag racer" developers."
(Scott Marlowe)