public inbox for [email protected]  

help / color / mirror / Atom feed

From: Noah Misch <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Separators in pg_hosts.conf fields
Date: Sun, 26 Apr 2026 14:54:25 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Sun, Apr 26, 2026 at 11:40:13PM +0200, Daniel Gustafsson wrote:
> > On 26 Apr 2026, at 23:32, Noah Misch <[email protected]> wrote:
> > 
> > If the build directory name contains a comma,
> > src/test/modules/ssl_passphrase_callback fails on master since commit 4f43302.
> > It fails because hba.c:next_token() treats a comma as a token separator:
> 
> Ugh, thanks for reporting.
> 
> > * Tokens can be delimited by double quotes (this allows the inclusion of
> > * commas, blanks, and '#', but not newlines).  As in SQL, write two
> > * double-quotes to represent a double quote.
> > 
> > Commit 4f43302 documented the pg_hosts.conf hostname field as a
> > comma-separated list, but not the other fields.  Should other pg_hosts.conf
> > fields continue to require quoting around commas, or not?
> 
> Yes, only the hostname field is a comma-separated list.  I think this should be
> added to the documentation as well on top of the test fix in your patch.

Do you anticipate docs like "this isn't a list, but the file's general parsing
rules require quotes if there's a comma"?  Or something different?

> Do
> you want me to take care of both parts?

That's fine.  I also don't mind pushing what I sent.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Separators in pg_hosts.conf fields
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox