Date: Mon, 27 Apr 2026 20:32:07 +0900
From: Yugo Nagata <nagata@sraoss.co.jp>
To: Sami Imseih <samimseih@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Pgsql Hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: Track skipped tables during autovacuum and autoanalyze
Message-Id: <20260427203207.32aa6ca37f2a18a05508dfda@sraoss.co.jp>
In-Reply-To: 
 <CAA5RZ0tUHU-r=Tc47P2DZyytF7x5h5OwBiRABe_dZt+zWNqe9g@mail.gmail.com>
References: <20260324151133.7940a5c1f2ebd594d54da481@sraoss.co.jp>
	<CAA5RZ0snnePNW1NKGKh+NyJ1CY26T5F_6-tTq+BHWM2kj1fN1g@mail.gmail.com>
	<20260325012847.e026ba1860c07288efe3e97d@sraoss.co.jp>
	<20260326192203.e6dbb8d80f8d27dc15ceee59@sraoss.co.jp>
	<acW8MW-Gb8Aj_TH2@paquier.xyz>
	<20260327163549.b5df519c0099970ddbb3412d@sraoss.co.jp>
	<CAA5RZ0tNh03LLgJVMA=PXSdY8YVoui4_GyfbfTrYK5cka3Q9Rw@mail.gmail.com>
	<20260328161802.f35b5a3e739566ffd7c1053b@sraoss.co.jp>
	<20260413170551.5ec43ba5a2c848f0d46c6a0b@sraoss.co.jp>
	<CAA5RZ0tUHU-r=Tc47P2DZyytF7x5h5OwBiRABe_dZt+zWNqe9g@mail.gmail.com>
Content-Type: multipart/mixed;
 boundary="Multipart=_Mon__27_Apr_2026_20_32_07_+0900_jUJUG74bF5asMQ6P"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?zHuVeRxfq0nq7RzRIxaR88he6hLDtogFvN2cWUZe8tbxhamm+5xKvJZXrcby?=
 =?us-ascii?Q?WtWEPuXeww4nlLYA69YQpzYQr9QhPavqw+4LK2B8ugBMIBXZMbmYNTFi8RBy?=
 =?us-ascii?Q?jesOt6G0CTEFLXQyroxoG7BcsBslyc6c53SZRx/iRhHuY5IA/qzePNyhPH0N?=
 =?us-ascii?Q?BefQZOGKsSpAKRPwSMwWrQ938lS6AeQ8XlncBShl7BEG9bpVDEfyocZg94+3?=
 =?us-ascii?Q?jtjio3qPVkKcYyisB8yzZWQ48Q4VHWlk5HM6N2O8Uo1y/ri8EbUJQPgFQKZB?=
 =?us-ascii?Q?soop/yH5BEDlVHoKiQ1UnqT0Fr+StgoA2Wr1lMDX0q6EV1lMhaqNkQ16WOyx?=
 =?us-ascii?Q?Qk1E08W6w4Q7lM5QHRn7wCpityVr8GPD8xNd7fsN1X3mGKb00Lczox+zUyjB?=
 =?us-ascii?Q?biCefM7h29H1NB/i09RcFRzM8e6alrz1Iad6OTfHYpr7GEvd5e9PH39YPWGF?=
 =?us-ascii?Q?k+o2HNS48dBqmqPPUaPN5DuccUbNxPJWsSx7vLiwd9v/ORneFUz6izeoadIT?=
 =?us-ascii?Q?y7804QuoVmgfrB7GChFKstBUGLUrkKoHb+nBgrJWqm8Pnii/zKyBnzYvw02L?=
 =?us-ascii?Q?d3p5Rz2V0OoJJ0HGQZvQTAPk/c6vfzlVGmOiJhpo5Xry0jWdEMro3FmZN3xV?=
 =?us-ascii?Q?JEnJGr/J64tvHk86Ea6Z0XIOSWZ3RWsGl54OrYfXi0g64qoPZGe1pUQLgKRB?=
 =?us-ascii?Q?7olJ4Bz5gzgdP94JBflKlpYUClQHSZ2n2m8BY0e4amcuNbVfDLnz0hh7Zei5?=
 =?us-ascii?Q?oMIEJt9iq8SAxC27QfPjrRRa2F4R/29uFinn8SQYMiKLmp7WCGz5lbIKs4Rb?=
 =?us-ascii?Q?J/wqdYlDiKAiAqQR1lGbA8Sq64GqTsdIVVQwQKnnnIh18FZbc2/4z4nKVO0h?=
 =?us-ascii?Q?b/M4KKpkL7/IZ+VaEdjdOzVNdaIR7CH/ZeOy8VLueZOGXTMPVQb62Q5q5/qG?=
 =?us-ascii?Q?7KL8cLMHm8Yp0TM9cjooFgRChJEUG/I59le2blEbM3ehGXme5ELp2WNKzfPO?=
 =?us-ascii?Q?tyhhasQE6GhoWZxl2t/acgYOrfwuNBMLB66WxHXqqQn7Bem/vGQSF01RsbKu?=
 =?us-ascii?Q?kL6DM7YyhVFK+KmgiCvhG0ibQ1K3iqPolec3KyKstfCTbQtbnNagta5FLAYz?=
 =?us-ascii?Q?lvF56f1i8mh8Hq8VpOeK6yg3nQTd0PRtx1iLOvdvby5dMhnnxvxPIgDJdMeX?=
 =?us-ascii?Q?+Sv9JqNC/v1+DVxENp19MoHrEbJjf4J0vUFD9C9JWHnAc8s/nXMUwnHI/CvM?=
 =?us-ascii?Q?WAU6MEd/zg9P5WHHlyGDjy6J+m4GF2Kr2dukyZOGYgwkT8LkfqUiV0wMaU7F?=
 =?us-ascii?Q?rX2nX1pG2DJjxxVV+hLSqnjQsmMDWamsi3UJja+/jb9tEMGYZ/bxHv0GMc8P?=
 =?us-ascii?Q?OKTar6i68yqk1Y41agk/cNQtH3i0CMwaB2IeeRV+f4QCfgH+G3HGcJm55MDl?=
 =?us-ascii?Q?hs1J5Uwbop8HvVIFtj4e9JV7SdwoE3JASR+EGB0reDTmJdq3mc0x3d6ijmKr?=
 =?us-ascii?Q?sWbSNkPl/nHa5MjZ1Rt9fJfYBwJIFrFB3ND5d7VU0LwBU8nqakBXBjhnksan?=
 =?us-ascii?Q?qe2xbHqGNxO0Krp6uOVuGR8fhHTgkF7N8rQAlaNQ26dqo6/kwYAA9yuh/Kc3?=
 =?us-ascii?Q?k99hPf0W10hlu9KlynyK2BBxDybqVtLHWYJ/FhwNUaBAyjxvV1GnE1Xe9HKV?=
 =?us-ascii?Q?1SqjKXpa2+OvE/fx6jk+2e3jHFivo6pKHcVydSzH2xRk2C14026Ja5TbSR/D?=
 =?us-ascii?Q?SQxyRHMUi+hPbJPGZWw6T/uw+7loaILp26OUCSM7cFoO9lOxQBLt?=
X-OriginatorOrg: sraoss.co.jp
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 751ea0b7-ee4a-414a-edff-08dea4509db6
X-MS-Exchange-CrossTenant-AuthSource: OSZP286MB2160.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2026 11:32:08.5083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 75db6c32-352e-4063-ae79-cafb8623f6db
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 TYJo3dhye5mVnBpu+2fdrX5h7lP/sffaMFkdG7mYS2gStiXoqg0tyvzKPlnnNlKMXIX/GYucgz7zFqT5i3GJ2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS9P286MB5206
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20260427203207.32aa6ca37f2a18a05508dfda%40sraoss.co.jp>
Precedence: bulk

--Multipart=_Mon__27_Apr_2026_20_32_07_+0900_jUJUG74bF5asMQ6P
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 22 Apr 2026 07:49:55 -0500
Sami Imseih <samimseih@gmail.com> wrote:

Thank you for your comments!
> 
> 1/
> 
> +            relid = RangeVarGetRelid(vrel->relation, NoLock, false);
> 
> Should this be called with "true" as the 3rd (missing_ok) argument, otherwise
> we end up with an error instead of a "--- relation no longer exists" log. right?

No, it should be false. If missing_ok is true, VACUUM (SKIP_LOCKED) on a not-existing
table would emit a "skipping vacuum of ... --- relation no longer exists" message, but
it should be "relation ... does not exist".

> 2/
> 
> Can the isolation tests
> src/test/isolation/specs/vacuum-skip-locked.spec be updated
> to check pg_stat_user_tables as well?

Yes, we can. I've attached an updated patch including that test.

While working on the test, I noticed that skipped FULL VACUUM was counted
in the previous patch, so I fixed it not to avoid counting those cases.

> 3/ comment fix:
> 
> This:
> * Relation could not be opened hence generate if possible a log
> 
> Should be:
> * Relation could not be opened, hence generate if possible a log

Fixed.

The names of the new fields are still open. The current pattern is
"last_skipped_..." and "skipped_..._count". Alternatively, we could use
"..._last_skip" and "..._skip_count", which would be consistent with
slotsync_skip_count and slosync_last_skip.

Which do you think is better?

Regards,
Yugo Nagata

-- 
Yugo Nagata <nagata@sraoss.co.jp>

--Multipart=_Mon__27_Apr_2026_20_32_07_+0900_jUJUG74bF5asMQ6P
Content-Type: text/x-diff;
 name="v5-0001-Track-skipped-vacuum-and-analyze-activity-per-rel.patch"
Content-Disposition: attachment;
 filename="v5-0001-Track-skipped-vacuum-and-analyze-activity-per-rel.patch"
Content-Transfer-Encoding: 7bit