Date: Tue, 05 May 2026 17:08:45 +0900 (JST)
Message-Id: <20260505.170845.1271951360939093763.ishii@postgresql.org>
To: jian.universality@gmail.com
Cc: assam258@gmail.com, zsolt.parragi@percona.com, sjjang112233@gmail.com,
 vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com,
 david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: Row pattern recognition
From: Tatsuo Ishii <ishii@postgresql.org>
In-Reply-To: 
 <CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67+HDAQ@mail.gmail.com>
References: <20260502.140304.670813149418899420.ishii@postgresql.org>
	<20260505.090124.365339750969814137.ishii@postgresql.org>
	<CACJufxEWL_ZnC-bs_yrg-Ys6ZUD3Ut_p1Ebj0bAcbzj67+HDAQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20260505.170845.1271951360939093763.ishii%40postgresql.org>
Precedence: bulk

Hi Jian,

> Hi
> The patchset is too big, I only downloaded v47-0001...

Yeah, since the feature is complex...

> 1. We need to add trailing commas to enum definitions. See
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7

I forgot that. Thanks for reminding.

> 2.
> + | '{' ',' Iconst '}' Op
> + {
> + if (strcmp($5, "?") != 0)
> + ereport(ERROR,
> + (errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("invalid token after range quantifier"),
> + errhint("Only \"?\" is allowed after {n,} or {,m} to make it reluctant."),
> + parser_errposition(@5)));
> + if ($3 <= 0 || $3 >= INT_MAX)
> + ereport(ERROR,
> + errcode(ERRCODE_SYNTAX_ERROR),
> + errmsg("quantifier bound must be between 1 and %d", INT_MAX - 1),
> + parser_errposition(@3));
> + $$ = (Node *) makeRPRQuantifier(0, $3, @5, @1, yyscanner);
> 
> + (errcode(ERRCODE_SYNTAX_ERROR),
> The leading parenthesis is optional and can be removed, fewer
> parentheses are always better.
> See related discussion:
> https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql

Right. I will review all other patches.

> Since v47-0001 introduces many ereport(ERROR) messages, it makes sense
> to move the related regression tests from the other patch into
> v47-0001, IMHO.

Thanks for the suggestion but I do not agree the direction.  It will
make the patch maintenance work harder. Also it will make it difficult
to understand the regression test organization.

Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp